Group member can't paginate through group pages

Bug #1770496 reported by Robert Lyon on 2018-05-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Unassigned
18.10
High
Unassigned

Bug Description

When the following settings are being used:

1) Site options -> General settings -> Allow public pages = false
2) Group settings -> Publicly viewable group = true
3) Group has a bunch of pages so that the "Group portfolios" block has pagination happening

If a normal group member goes to the group homepage and tries to paginate through "Group portfolios" they get an 'Access denied' error.

Public profile pages do ignore the 'allow public pages' switch when 'false' - as that switch is only meant for portfolio pages and not special pages.

As the group home page is also a special page it also needs to be respected as such.

Reviewed: https://reviews.mahara.org/8849
Committed: https://git.mahara.org/mahara/mahara/commit/7d9d1b29a26edb1b0675cc0c7c6bff235cbbbe1e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7d9d1b29a26edb1b0675cc0c7c6bff235cbbbe1e
Author: Robert Lyon <email address hidden>
Date: Fri May 11 08:32:48 2018 +1200

Bug 1770496: Validate access for member to a public group

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8854

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8855

Reviewed: https://reviews.mahara.org/8855
Committed: https://git.mahara.org/mahara/mahara/commit/c38cc3732247a25bc62b2b2d683f8b2a2c017b15
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit c38cc3732247a25bc62b2b2d683f8b2a2c017b15
Author: Robert Lyon <email address hidden>
Date: Fri May 11 08:32:48 2018 +1200

Bug 1770496: Validate access for member to a public group

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d9d1b29a26edb1b0675cc0c7c6bff235cbbbe1e)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8854
Committed: https://git.mahara.org/mahara/mahara/commit/f27ca90051c777b29dddb6ae57e5c59ed55bb77f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit f27ca90051c777b29dddb6ae57e5c59ed55bb77f
Author: Robert Lyon <email address hidden>
Date: Fri May 11 08:32:48 2018 +1200

Bug 1770496: Validate access for member to a public group

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d9d1b29a26edb1b0675cc0c7c6bff235cbbbe1e)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8853
Committed: https://git.mahara.org/mahara/mahara/commit/3373d790c1561063d251129292933160ac9d3ceb
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 3373d790c1561063d251129292933160ac9d3ceb
Author: Robert Lyon <email address hidden>
Date: Fri May 11 08:32:48 2018 +1200

Bug 1770496: Validate access for member to a public group

When site public pages are turned off.

If the user is a member of a group that has 'public' access and the
site 'Allow public pages' are turned off, the user should be able to
view the group's home page - therefore allowing them to paginate
through the "Group portfolios" block in the group home page.

behatnotneeded

Change-Id: I1ea49927532f967c8a676b8a1590d1db3787cfc2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 7d9d1b29a26edb1b0675cc0c7c6bff235cbbbe1e)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers