duplicated id="login_login_submitted" in login form
Bug #1770261 reported by
Cecilia Vela Gurovic
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Low
|
Cecilia Vela Gurovic | ||
Bug Description
as a logged out user in home screen the login form is fine,
but if we add /?login to the url we can see that the id="login_
is duplicated in the DOM
It's easy to see in chrome since it shows and error in the browser console
[DOM] Found 2 elements with non-unique id #login_
| Changed in mahara: | |
| milestone: | none → 18.10.0 |
Revision history for this message
| Cecilia Vela Gurovic (ceciliavg) wrote | #1 |
| Changed in mahara: | |
| status: | New → Confirmed |
| tags: | added: code-cleanup |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A patch has been submitted for review | #2 |
| Changed in mahara: | |
| status: | Confirmed → In Progress |
| assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #3 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I can see we create the login form in a different way if it's not in a sideblock.
We call function auth_get_login_form from auth/lib.php that includes an extra 'login_submitted' pieform element but I'm not sure why we do that.