find_by_email_address() and MySql problem

Bug #1769512 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
17.10
Fix Released
High
Unassigned
18.04
Fix Released
High
Unassigned

Bug Description

The SQL for finding a user by email address fails to execute in a timely manner in mysql.

This is due to grouping on subquery when trying to return ID's for IN() clause.

We need to nest another query between so the IN() clause gets a known list if IDs with out any group by clause

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8826
Committed: https://git.mahara.org/mahara/mahara/commit/94c1c750000a0a27ba0fe7747154f988dae059ea
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 94c1c750000a0a27ba0fe7747154f988dae059ea
Author: Robert Lyon <email address hidden>
Date: Mon May 7 09:43:58 2018 +1200

Bug 1769512: Need to nest the query better for mysql to handle

Otherwise the query just hangs

behatnotneeded

Change-Id: If3d022f87f83e14a512527a47cca2093b2ba74aa
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8876

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8877

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8876
Committed: https://git.mahara.org/mahara/mahara/commit/7773892d9202572a9417b12a9a4e7df4483c30fa
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 7773892d9202572a9417b12a9a4e7df4483c30fa
Author: Robert Lyon <email address hidden>
Date: Mon May 7 09:43:58 2018 +1200

Bug 1769512: Need to nest the query better for mysql to handle

Otherwise the query just hangs

behatnotneeded

Change-Id: If3d022f87f83e14a512527a47cca2093b2ba74aa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 94c1c750000a0a27ba0fe7747154f988dae059ea)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8877
Committed: https://git.mahara.org/mahara/mahara/commit/2bc9d3aabfc79e8df289231362e043dfe6bbaf36
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 2bc9d3aabfc79e8df289231362e043dfe6bbaf36
Author: Robert Lyon <email address hidden>
Date: Mon May 7 09:43:58 2018 +1200

Bug 1769512: Need to nest the query better for mysql to handle

Otherwise the query just hangs

behatnotneeded

Change-Id: If3d022f87f83e14a512527a47cca2093b2ba74aa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 94c1c750000a0a27ba0fe7747154f988dae059ea)

Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers