'Search results for' link in My Tags page not working correctly

Bug #1767867 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
17.04
Fix Released
Undecided
Unassigned
17.10
Fix Released
Undecided
Unassigned
18.04
Fix Released
Medium
Unassigned
18.10
Fix Released
Medium
Robert Lyon

Bug Description

It sometimes gets confused and tries to create a URL without the ? char but only the & char

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8815
Committed: https://git.mahara.org/mahara/mahara/commit/c185b03da19da72b4daaf92d6c41d94a150bb51d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c185b03da19da72b4daaf92d6c41d94a150bb51d
Author: Robert Lyon <email address hidden>
Date: Fri Apr 27 13:04:09 2018 +1200

Bug 1767867: Using correct base url for My tags 'Search results for' link

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8928

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8928
Committed: https://git.mahara.org/mahara/mahara/commit/7d37d9b291e1cbbb47a7f23c94647ad07d17d8bc
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 7d37d9b291e1cbbb47a7f23c94647ad07d17d8bc
Author: Robert Lyon <email address hidden>
Date: Fri Apr 27 13:04:09 2018 +1200

Bug 1767867: Using correct base url for My tags 'Search results for' link

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c185b03da19da72b4daaf92d6c41d94a150bb51d)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8940

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8940
Committed: https://git.mahara.org/mahara/mahara/commit/0f7d3e3a73857a0836754b1b7ccabe876327ecf3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 0f7d3e3a73857a0836754b1b7ccabe876327ecf3
Author: Robert Lyon <email address hidden>
Date: Fri Apr 27 13:04:09 2018 +1200

Bug 1767867: Using correct base url for My tags 'Search results for' link

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c185b03da19da72b4daaf92d6c41d94a150bb51d)
(cherry picked from commit 7d37d9b291e1cbbb47a7f23c94647ad07d17d8bc)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8941

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8941
Committed: https://git.mahara.org/mahara/mahara/commit/3fc5190a3e423c4948a1a954c28af3c79bdac36f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 3fc5190a3e423c4948a1a954c28af3c79bdac36f
Author: Robert Lyon <email address hidden>
Date: Fri Apr 27 13:04:09 2018 +1200

Bug 1767867: Using correct base url for My tags 'Search results for' link

behatnotneeded

Change-Id: I0eef9a361cda68ca6274d64308354dc239cc46bc
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c185b03da19da72b4daaf92d6c41d94a150bb51d)
(cherry picked from commit 7d37d9b291e1cbbb47a7f23c94647ad07d17d8bc)
(cherry picked from commit 0f7d3e3a73857a0836754b1b7ccabe876327ecf3)

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

steps to reproduce:

create a page and add a tag in the settings with text "One"

display the page

click on the tag

you will see a heading with the text "Search results for One"

"One" in that text should be a link. Click on it.

Expected result: the page is refreshed and filters the result with the tag name
Actual result: the url of the link is malformed and you are redirected to a 404 page

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers