Capitalisation of username / email address issue with LTI

Bug #1763581 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
17.04
Fix Released
High
Unassigned
17.10
Fix Released
High
Unassigned
18.04
Fix Released
High
Robert Lyon
18.10
Fix Released
High
Unassigned

Bug Description

Mahara respects the capitalisation of usernames and email addresses when an external authentication source like LDAP, Active Directory, or a SAML IdP is connected. However, when accounts come from Canvas, they are all lowercase causing problems. Catalyst will fix this issue so that users are put into the same account no matter whether they come from an external authentication method of from Canvas via LTI.

This is an issue because double accounts are set up otherwise.

description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8804

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8804
Committed: https://git.mahara.org/mahara/mahara/commit/80c5e70a9684fbd933c10299282461362c6af84d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 80c5e70a9684fbd933c10299282461362c6af84d
Author: Robert Lyon <email address hidden>
Date: Tue Apr 17 11:36:34 2018 +1200

Bug 1763581: Check email based usernames in lowercase for LTI

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8873

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8874

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8875

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8873
Committed: https://git.mahara.org/mahara/mahara/commit/74cc86812b6d4ff65ffd5ea5916a7665c87b00fe
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 74cc86812b6d4ff65ffd5ea5916a7665c87b00fe
Author: Robert Lyon <email address hidden>
Date: Tue Apr 17 11:36:34 2018 +1200

Bug 1763581: Check email based usernames in lowercase for LTI

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 80c5e70a9684fbd933c10299282461362c6af84d)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8875
Committed: https://git.mahara.org/mahara/mahara/commit/64af9324e1a01ffe8f5f491720b68ea89febf097
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 64af9324e1a01ffe8f5f491720b68ea89febf097
Author: Robert Lyon <email address hidden>
Date: Tue Apr 17 11:36:34 2018 +1200

Bug 1763581: Check email based usernames in lowercase for LTI

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 80c5e70a9684fbd933c10299282461362c6af84d)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8874
Committed: https://git.mahara.org/mahara/mahara/commit/12cd2e9cfc6cc451740436566d5c0edde944d903
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 12cd2e9cfc6cc451740436566d5c0edde944d903
Author: Robert Lyon <email address hidden>
Date: Tue Apr 17 11:36:34 2018 +1200

Bug 1763581: Check email based usernames in lowercase for LTI

In Mahara we compare supplied usernames in lower case to what exists
in the database. This avoids problems of 'test01' vs 'Test01'.

The LTI plugin needs to also adhere to this convention

behatnotneeded

Change-Id: I822ccf9e3e3c3b43533c503f1600ef3c3af8008e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 80c5e70a9684fbd933c10299282461362c6af84d)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers