simplesaml upgrade causes ext-pdo_sqlite error

[Rebecca Blundell]

Steps to reproduce:
Upgrade to 18.04
Go to admin -> extensions -> plugin administration
Click on saml settings.
You see an error message that you need to run make ssphp to upgrade saml.

running make ssphp causes the following error:
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested PHP extension ext-pdo_sqlite * is missing from your system. Install or enable PHP's pdo_sqlite extension.

Installation failed, reverting ./composer.json to its original content.
Makefile:64: recipe for target 'ssphp' failed
make: *** [ssphp] Error 2

apt-get install fails to find a package called any of the following:
ext-pdo_sqlite
php ext-pdo_sqlite
php pdo_sqlite
pdo_sqlite
php7.0-ext-pdo_sqlite
php7.0-pdo_sqlite

On further investigation, it appears the Makefile is installing simplesaml with it's composer requirements, so perhaps this extension should not be included in the requirements.

[Kristina Hoeppner (kris-hoeppner)]

From the online chat when we talked about this:

"the make ssphp gives an error with sqlite because we install via composer rather than src - due to the changes for redis and ssphp
we only need the sqlite to exist as part of install via Make"

[Kristina Hoeppner (kris-hoeppner)]

We could add this to the message that lists all the extensions that need to be installed when you install SAML for the first time.

[Gold (gold.catalyst)]

Missing that conversation, the comments here aren't too clear.

Should the extra message be added to the error message on the Plugin administration: auth: saml page or should it be added to the ssphp target in the Makefile?

If an sqlite extension is needed for the Makefile approach the it's simple enough to check if the extension is installed and bail with a message if not.