Mahara

Leap2A export warnings on comment/annotation

Bug #1758757 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
Mahara 18.04.0
18.04
Fix Released
Medium
Robert Lyon
Mahara 18.04.0
18.10
Fix Released
Medium
Unassigned
Mahara 18.10.0

Bug Description

On doing an export in PHP 7.0/7.1 I see these warnings

[WAR] 4a (export/leap/lib.php:406) Parameter 1 to LeapExportElementComment::setup_links() expected to be a reference, value given, referer: http://testing/export/index.php

[WAR] 4a (export/leap/lib.php:406) Parameter 1 to LeapExportElementAnnotation::setup_links() expected to be a reference, value given, referer: http://testing/export/index.php

In the Mahara code it says:
"You must explicitly pass variables by reference when calling call_user_func, ..."

But in PHP manual itself it says "Note that the parameters for call_user_func() are not passed by reference."

So there is something not quite right here

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8713

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8713
Committed: https://git.mahara.org/mahara/mahara/commit/1932d334e0f02ed31c99aa60ca498801bc04cbb3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 1932d334e0f02ed31c99aa60ca498801bc04cbb3
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 10:35:42 2018 +1300

Bug 1758757: setup_links() expected to be a reference, value given error

We used call_user_func() but i think we need to use
call_user_func_array() for this

behatnotneeded

Change-Id: I94dad0b59be8bab7ac6b2e1c45a6968ac4ece9fa
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8733

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8733
Committed: https://git.mahara.org/mahara/mahara/commit/ec4fb1209a6402e7e257cd9a62b0f0ab6004c260
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit ec4fb1209a6402e7e257cd9a62b0f0ab6004c260
Author: Robert Lyon <email address hidden>
Date: Mon Mar 26 10:35:42 2018 +1300

Bug 1758757: setup_links() expected to be a reference, value given error

We used call_user_func() but i think we need to use
call_user_func_array() for this

behatnotneeded

Change-Id: I94dad0b59be8bab7ac6b2e1c45a6968ac4ece9fa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1932d334e0f02ed31c99aa60ca498801bc04cbb3)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.