Group edit homepage "Settings" button shows wrong message with skins enabled

Bug #1758226 reported by Cecilia Vela Gurovic on 2018-03-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Cecilia Vela Gurovic
18.04
Low
Cecilia Vela Gurovic
18.10
Low
Unassigned

Bug Description

To replicate:

Create a group and edit the homepage.
If we have skins enabled ($cfg->skins = true), we will see there is a "Settings" button. If skins is disabled then we see "Edit layout" button instead.
When we hover over the button a box is displayed.

Expected result: The message in the box has the same text as the button.

Actual result: The box shows "Edit layout" in both cases.

Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/8711
Committed: https://git.mahara.org/mahara/mahara/commit/5deb0a54d7a5d095dd8eeff6e955443c41d525b1
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5deb0a54d7a5d095dd8eeff6e955443c41d525b1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Mar 23 16:11:35 2018 +1300

Bug 1758226: Showing correct message in view edit button

behatnotneeded

Change-Id: Ia5863a8e45da3a5b8b9f7ea5fec8a20b17708163

Reviewed: https://reviews.mahara.org/8721
Committed: https://git.mahara.org/mahara/mahara/commit/79eaa929b86c7dff2dd2342fedaadbb9190d3210
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 79eaa929b86c7dff2dd2342fedaadbb9190d3210
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Mar 23 16:11:35 2018 +1300

Bug 1758226: Showing correct message in view edit button

behatnotneeded

Change-Id: Ia5863a8e45da3a5b8b9f7ea5fec8a20b17708163
(cherry picked from commit 5deb0a54d7a5d095dd8eeff6e955443c41d525b1)

Robert Lyon (robertl-9) on 2018-03-26
Changed in mahara:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers