The views.js file uses the javascript 'includes' function but this is not available to IE11

Bug #1757283 reported by Robert Lyon on 2018-03-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
17.10
High
Unassigned
18.04
High
Robert Lyon
18.10
High
Unassigned

Bug Description

We have:
 if (embedjs.includes("AC_Voki_Embed")) {

We need:
 if (embedjs.indexOf("AC_Voki_Embed") !== -1) {

Robert Lyon (robertl-9) on 2018-03-20
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)

How to replicate:

On IE 11

1. Set up a page.
2. Add a "Files to download" block and select a file.
3. Save
Expected result: The block configuration closes on its own and the block is saved.
Actual result: The block configuration stays open and the spinner is visible.

Reviewed: https://reviews.mahara.org/8673
Committed: https://git.mahara.org/mahara/mahara/commit/0465c54d32824decd8d17e3d10f02d0d3077cc1e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 0465c54d32824decd8d17e3d10f02d0d3077cc1e
Author: Robert Lyon <email address hidden>
Date: Wed Mar 21 11:47:32 2018 +1300

Bug 1757283: Use more generic javascript syntax to help IE

The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/8694
Committed: https://git.mahara.org/mahara/mahara/commit/a4b81e7deac0bc29773ca559505b590226802965
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit a4b81e7deac0bc29773ca559505b590226802965
Author: Robert Lyon <email address hidden>
Date: Wed Mar 21 11:47:32 2018 +1300

Bug 1757283: Use more generic javascript syntax to help IE

The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0465c54d32824decd8d17e3d10f02d0d3077cc1e)

Reviewed: https://reviews.mahara.org/8695
Committed: https://git.mahara.org/mahara/mahara/commit/18e5acaa322dd831dcd326a9de33316377d5b12e
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 18e5acaa322dd831dcd326a9de33316377d5b12e
Author: Robert Lyon <email address hidden>
Date: Wed Mar 21 11:47:32 2018 +1300

Bug 1757283: Use more generic javascript syntax to help IE

The includes() method not available for IE 11

behatnotneeded

Change-Id: Ice40becaacb391bc7b4f85ebf533f9b049e2a5a2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0465c54d32824decd8d17e3d10f02d0d3077cc1e)
(cherry picked from commit a4b81e7deac0bc29773ca559505b590226802965)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers