The page "more" link menu sometimes looks broken

Bug #1757254 reported by Robert Lyon on 2018-03-20
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
18.04
High
Robert Lyon
18.10
High
Unassigned

Bug Description

When I view the page as myself things look fine and also when a logged out user

But when viewing as another logged in user things look broken

See attached image

Robert Lyon (robertl-9) wrote :
tags: added: front-end
Robert Lyon (robertl-9) wrote :

Looks to have been broken in commit

8d796e7ca04b6df776b5deeb07cf38b9c7b037c0

I suspect the datapicker css changes broke this as there is a bunch of css in bottom of https://reviews.mahara.org/#/c/8469/15/htdocs/theme/raw/sass/components/_datepicker.scss
that look to override things that are meant to be set via variables

Changed in mahara:
status: New → Confirmed
Liam (liam-sharpe) on 2018-03-21
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)

Reviewed: https://reviews.mahara.org/8679
Committed: https://git.mahara.org/mahara/mahara/commit/3927b6967fb95ddc0866feaa40833365ed7e8b31
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 3927b6967fb95ddc0866feaa40833365ed7e8b31
Author: Robert Lyon <email address hidden>
Date: Thu Mar 22 09:32:59 2018 +1300

Bug 1757254: Target the datepicker styles more directly

To avoid them overriding the same styles being used elsewhere

behatnotneeded

Change-Id: I092d841224a811b8a1f398b9fe2bf76e5e9a143d
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/8705
Committed: https://git.mahara.org/mahara/mahara/commit/06678effc62921a8b31e9227a9802913b21f51ee
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 06678effc62921a8b31e9227a9802913b21f51ee
Author: Robert Lyon <email address hidden>
Date: Thu Mar 22 09:32:59 2018 +1300

Bug 1757254: Target the datepicker styles more directly

To avoid them overriding the same styles being used elsewhere

behatnotneeded

Change-Id: I092d841224a811b8a1f398b9fe2bf76e5e9a143d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 3927b6967fb95ddc0866feaa40833365ed7e8b31)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments