share/edit access cancel button not working

Bug #1756764 reported by Steven on 2018-03-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned
18.04
Medium
Unassigned
18.10
Medium
Unassigned

Bug Description

Environment tested: Master
Browser tested: MS Edge (Virtualbox) | Chrome Linux

===================
Manual Test Script
===================

Preconditions:
1) user has portfolio page to share
2) User has no friends but 1 friend request

Test Steps:
1) user is on the "Share | Edit access" page for the page they want to share
2) user selects "Friends" under the search for section of the "SHARED WITH" drop down field
3) a search field is now displayed but returns no results, because user has not friends yet

Actual result:
User tries to click Cancel to get out of page but nothing happens, there is no error message describing what he has done wrong. User must delete the field before the cancel button works, returning user to "Share"

Expected result:
1) Save button should not work because I have search friends field open and no friend selected
2) Cancel button should work and take user back to previous page

Tags: ux Edit Tag help
Changed in mahara:
milestone: none → 18.10.0
importance: Undecided → Medium
status: New → Confirmed
tags: added: ux
Robert Lyon (robertl-9) on 2018-03-21
Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/8683
Committed: https://git.mahara.org/mahara/mahara/commit/55c50c1cd0f0260cb0c7f0997a62e6e8e4494205
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 55c50c1cd0f0260cb0c7f0997a62e6e8e4494205
Author: Robert Lyon <email address hidden>
Date: Thu Mar 22 10:21:06 2018 +1300

Bug 1756764: Alert user if shared with rules 2nd option empty

This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/8706
Committed: https://git.mahara.org/mahara/mahara/commit/d5d67ffe4f3ed1607623a0c2bcae8f79b325468b
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit d5d67ffe4f3ed1607623a0c2bcae8f79b325468b
Author: Robert Lyon <email address hidden>
Date: Thu Mar 22 10:21:06 2018 +1300

Bug 1756764: Alert user if shared with rules 2nd option empty

This is for the 'Search for...' Friends / Groups / Users

Currently we don't allow the submission / cancel of the form if any of
these 3 options are selected but the second select2 box is empty

But we also don't tell the user why.

I've added an alert to mention why the form will not submit / cancel

behatnotneeded

Change-Id: I71827647fd7a2f8177c336bdb91f6ce8b9b23df8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 55c50c1cd0f0260cb0c7f0997a62e6e8e4494205)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers