tinyMCE not defined error in comment on SE colection

Bug #1755674 reported by Cecilia Vela Gurovic on 2018-03-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Cecilia Vela Gurovic
18.10
High
Unassigned

Bug Description

to test:

Go to admin menu-> Extensions -> Plugin admin and enable annotations
create a page and add an annotation to it
share it with Public
log out and go to the collection first page (not SE view table)
try to leave a comment as anonymous user

the page will be stuck loading and the comment is never submitted
in the browser's console we can see the error:

Uncaught ReferenceError: tinyMCE is not defined
    at isTinyMceUsed (annotation.js?v=7998:14)
    at addFeedbackSuccess (viewmenu.js?v=7998:37)
    at Object.window.pieformHandlers.(/view/anonymous function) [as add_feedback_form] (https://mahara/lib/pieforms/static/core/pieforms.js?v=7998:239:60)
    at sendResult (view.php?id=7:4)
    at onload (view.php?id=7:7)

Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)

As we are not using a tinyMCE form for comments when logged out but instead a normal text field, there is an exception in annotation.js file.
It fails when calling isTinyMceUsed()

description: updated

Reviewed: https://reviews.mahara.org/8628
Committed: https://git.mahara.org/mahara/mahara/commit/b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Mar 15 08:50:36 2018 +1300

Bug 1755674: check tinyMCE is not used in anonymous comments

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1

Reviewed: https://reviews.mahara.org/8651
Committed: https://git.mahara.org/mahara/mahara/commit/2a65c6d7ec3990aed232b4e2a9b37caaa345f44b
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 2a65c6d7ec3990aed232b4e2a9b37caaa345f44b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Mar 15 08:50:36 2018 +1300

Bug 1755674: check tinyMCE is not used in anonymous comments

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322)

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8653

Reviewed: https://reviews.mahara.org/8653
Committed: https://git.mahara.org/mahara/mahara/commit/6905f66a6543f9f4f848c82d2cf57565e2a290e2
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 6905f66a6543f9f4f848c82d2cf57565e2a290e2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Mar 15 08:50:36 2018 +1300

Bug 1755674: check tinyMCE is not used in anonymous comments

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322)
(cherry picked from commit 2a65c6d7ec3990aed232b4e2a9b37caaa345f44b)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8652
Committed: https://git.mahara.org/mahara/mahara/commit/b0c5ccc7e2b99cf84488e64e71072fe74128d011
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit b0c5ccc7e2b99cf84488e64e71072fe74128d011
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Mar 15 08:50:36 2018 +1300

Bug 1755674: check tinyMCE is not used in anonymous comments

behatnotneeded

Change-Id: I17b0520d692e418d48629af790f11bb5f6682cf1
(cherry picked from commit b86b8a04e84c1fd5cd1ddcc453bb898e1c95f322)
(cherry picked from commit 2a65c6d7ec3990aed232b4e2a9b37caaa345f44b)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers