Should not call non static function statically in framework module

Bug #1755611 reported by Cecilia Vela Gurovic on 2018-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Robert Lyon
18.10
High
Robert Lyon

Bug Description

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called statically in htdocs/module/framework/lib.php on line 107

Changed in mahara:
status: New → Confirmed

Reviewed: https://reviews.mahara.org/8592
Committed: https://git.mahara.org/mahara/mahara/commit/53914399050b50da11776710c9f03354dfff19bd
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 53914399050b50da11776710c9f03354dfff19bd
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:56:30 2018 +1300

Bug 1755611: Should not call non static function statically in framework module

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8689

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8690

Reviewed: https://reviews.mahara.org/8688
Committed: https://git.mahara.org/mahara/mahara/commit/ffa1f84fd5460746c9a2e81160ab1f30d971c8aa
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit ffa1f84fd5460746c9a2e81160ab1f30d971c8aa
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:56:30 2018 +1300

Bug 1755611: Should not call non static function statically in framework module

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 53914399050b50da11776710c9f03354dfff19bd)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8689
Committed: https://git.mahara.org/mahara/mahara/commit/dfd87a2443c5fb8c0b2ec48e027edafadf67a2fe
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit dfd87a2443c5fb8c0b2ec48e027edafadf67a2fe
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:56:30 2018 +1300

Bug 1755611: Should not call non static function statically in framework module

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 53914399050b50da11776710c9f03354dfff19bd)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8690
Committed: https://git.mahara.org/mahara/mahara/commit/e42528eae749777a4ffc8eebb6c6b774b5058b23
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit e42528eae749777a4ffc8eebb6c6b774b5058b23
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 10:56:30 2018 +1300

Bug 1755611: Should not call non static function statically in framework module

Get these deprecated warnings:
Non-static method PluginModuleFramework::add_matrix_to_db() should not be called
statically in htdocs/module/framework/lib.php on line 56
Non-static method PluginModuleFramework::matrix_is_valid_json() should not be called
statically in htdocs/module/framework/lib.php on line 107

behatnotneeded

Change-Id: I959b1364926a32b88fe9aaea147b5d38de6884b0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 53914399050b50da11776710c9f03354dfff19bd)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers