Unable to remove users from group when pagination is used

Bug #1755508 reported by mafen on 2018-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Cecilia Vela Gurovic
18.10
High
Cecilia Vela Gurovic

Bug Description

Version: Mahara Version 17.10.1
Server OS: Linux (CentOS 7.4.1708)
Client OS: Windows 10
Database: MySQL
Browser: Chrome

I am unable to remove users from groups when pagination is used and the user, which should be removed, is on a page higher than 1. I dont touch the sortorder and items per page settings, so standard sortorder "admin first" and "10 items per page" are used.

It works for users on the first page, but doesnt work on all other pages. It just redirects me back to page 1. There is no entry in the logfile.

mafen (mafen1) on 2018-03-14
description: updated

I could replicate this on the latest 17.10 and on master.

1. Create a group with controlled membership (to make adding of people easy).
2. Upload a CSV file with 30+ new users.
3. Add all these users to the group.
4. Go to "Members" in the group and there to page 2 or higher and click the "Remove from group" button.
Expected result: The user is deleted and the confirmation message "User removed" is displayed towards the top of the screen.
Actual result: You are just redirected to the first page of "Members".

Also confirmed for 17.04

It is also broken for user requests:

- Set in the group settings:
Open = 'No'
Requests = 'Yes'

- make more than 10 users request membership on this group.

- go to 'Members' tab and click 'Requests' link
- in the second page approve or add the member

Expected result: the user is added to the list of members or removed from requests
Actual result: We are redirected to the first page of the Requests and the user is still displayed in the second page

Reviewed: https://reviews.mahara.org/8667
Committed: https://git.mahara.org/mahara/mahara/commit/49ef1604d3f18bbf4e265ce523c017664dc94df3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 49ef1604d3f18bbf4e265ce523c017664dc94df3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970

Reviewed: https://reviews.mahara.org/8668
Committed: https://git.mahara.org/mahara/mahara/commit/08ff7cf6f6d4077593f8e303ff63868e3e3abb18
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8670

Reviewed: https://reviews.mahara.org/8669
Committed: https://git.mahara.org/mahara/mahara/commit/12dc894f6047280ff00aa0936d554f92799661da
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 12dc894f6047280ff00aa0936d554f92799661da
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)
(cherry picked from commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8670
Committed: https://git.mahara.org/mahara/mahara/commit/c872b0cc48c2130a69896d39e50545a788ba5a49
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit c872b0cc48c2130a69896d39e50545a788ba5a49
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 20 15:45:00 2018 +1300

Bug 1755508: group member remove/request add-deny with pagination

behatnotneeded

Change-Id: Id3f06d1b9873a4ad1112b924f6e5bf177c210970
(cherry picked from commit 49ef1604d3f18bbf4e265ce523c017664dc94df3)
(cherry picked from commit 08ff7cf6f6d4077593f8e303ff63868e3e3abb18)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers