Cannot copy group pages when pagination is used

Bug #1755331 reported by Kevin Dibble on 2018-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Cecilia Vela Gurovic
18.10
High
Cecilia Vela Gurovic

Bug Description

Version: Mahara Version 17.10.0
OS: Linux (Ubuntu)
Database: MySQL
Browser: Chrome

Issue:
Group pages are created that can be copied by group members

Pages for users to copy that require they navigation to page 2 or higher of a shared list
(using the pagination at the bottom)
Clicking Copy Reloads the page (the page is not copied)

Page 1 is unaffected

Can you please be more specific where you are performing the copying?

Changed in mahara:
status: New → Incomplete
Kevin Dibble (digitalskill) wrote :

This is on the group page that list all pages that can be copied.
There is a "copy" button on the right side for each page and paginiation at the bottom of the page.

Thank you for the clarification, Kevin.

To replicate:

1. Set up a group with 5 pages and make them copyable to the group.
2. On the group homepage, edit the group pages block and set the page limit to 1 or 2 per page for the "Group pages" section.
3. Log in as a non-admin member of the group (can also test with being group admin) and click the paginator in the "Group pages" section on the group homepage.
4. Click the "Copy page" button next to a page.
Expected result: You see the settings screen of a page to make changes to the details of the page that you just copied.
Actual result: You are taken to the first paginated page and stay on the group homepage.

This is only a problem when not on page 1 in the paginator.

Kevin, it would be great if you could test the patch linked here to check that it works for you as expected.

Kevin Dibble (digitalskill) wrote :

Hi Kristina,

The patch works in creating pages from the group copy area when paginated into page 2 or higher.
This was tested locally on Mahara 17.10.3 version in:
php 7.0.16
php 7.1.2

cheers

Reviewed: https://reviews.mahara.org/8728
Committed: https://git.mahara.org/mahara/mahara/commit/5ccfbdd3ef44e438d0fee77fe0808c0ed977fb99
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 5ccfbdd3ef44e438d0fee77fe0808c0ed977fb99
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Mar 26 17:49:44 2018 +1300

Bug 1755331: make the pieform for copying group views available

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb

Reviewed: https://reviews.mahara.org/8742
Committed: https://git.mahara.org/mahara/mahara/commit/c1b343d4fbacca65c572849d1356a058eec7f8d0
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit c1b343d4fbacca65c572849d1356a058eec7f8d0
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Mar 26 17:49:44 2018 +1300

Bug 1755331: make the pieform for copying group views available

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb
(cherry picked from commit 5ccfbdd3ef44e438d0fee77fe0808c0ed977fb99)

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8744

Reviewed: https://reviews.mahara.org/8744
Committed: https://git.mahara.org/mahara/mahara/commit/49a9e1f8ed695650dfb98d737dc0662f96779882
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 49a9e1f8ed695650dfb98d737dc0662f96779882
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Mar 26 17:49:44 2018 +1300

Bug 1755331: make the pieform for copying group views available

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb
(cherry picked from commit 5ccfbdd3ef44e438d0fee77fe0808c0ed977fb99)
(cherry picked from commit c1b343d4fbacca65c572849d1356a058eec7f8d0)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8743
Committed: https://git.mahara.org/mahara/mahara/commit/a5624f3e55367de80b69fb22ef755f0632dfcfd3
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit a5624f3e55367de80b69fb22ef755f0632dfcfd3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Mar 26 17:49:44 2018 +1300

Bug 1755331: make the pieform for copying group views available

when using pagination
behatnotneeded

Change-Id: Ia1c55442a66ff4581543db42615dcd5a3ee411bb
(cherry picked from commit 5ccfbdd3ef44e438d0fee77fe0808c0ed977fb99)
(cherry picked from commit c1b343d4fbacca65c572849d1356a058eec7f8d0)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers