Working out folder size slows down opening of image block config

Bug #1755329 reported by Robert Lyon on 2018-03-13
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Cecilia Vela Gurovic
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Cecilia Vela Gurovic
18.10
High
Cecilia Vela Gurovic

Bug Description

We added the fix for https://bugs.launchpad.net/mahara/+bug/1650980 so that we could know how much content a folder contained when viewing via Content -> Files
This was useful in helping one delete files to sort out quota problems.

But the problem is that bit of code is also used when displaying a filebrowser form in block config forms. And it slows down the opening/closing of the config.

We don't need to know about the folder / file size here so we should avoid the slow db calls that work out the size when not on Content -> Files page

Robert Lyon (robertl-9) on 2018-03-13
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
assignee: Robert Lyon (robertl-9) → nobody
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
no longer affects: mahara/18.10
no longer affects: mahara/18.10

Reviewed: https://reviews.mahara.org/8617
Committed: https://git.mahara.org/mahara/mahara/commit/ec18759b1833e6c3593d99e96144659a32f9d0e8
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit ec18759b1833e6c3593d99e96144659a32f9d0e8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 13 15:35:13 2018 +1300

Bug 1755329: Calculate folder size only in managing files pages

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8620

Mahara Bot (dev-mahara) wrote :

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8621

Reviewed: https://reviews.mahara.org/8621
Committed: https://git.mahara.org/mahara/mahara/commit/18dd32f1c270cdd2630a34bb6e9e10c7d15d99da
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 18dd32f1c270cdd2630a34bb6e9e10c7d15d99da
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 13 15:35:13 2018 +1300

Bug 1755329: Calculate folder size only in managing files pages

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0
(cherry picked from commit ec18759b1833e6c3593d99e96144659a32f9d0e8)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8620
Committed: https://git.mahara.org/mahara/mahara/commit/dff5f618fd489762c2e6bafa0de7bd88ad3b6529
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit dff5f618fd489762c2e6bafa0de7bd88ad3b6529
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 13 15:35:13 2018 +1300

Bug 1755329: Calculate folder size only in managing files pages

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0
(cherry picked from commit ec18759b1833e6c3593d99e96144659a32f9d0e8)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8619
Committed: https://git.mahara.org/mahara/mahara/commit/bec31339af4e32f7044292d127253c2d2aa65f18
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit bec31339af4e32f7044292d127253c2d2aa65f18
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 13 15:35:13 2018 +1300

Bug 1755329: Calculate folder size only in managing files pages

behatnotneeded

Change-Id: I3d9927777a543441ea00335e625fcd54b5d51ba0
(cherry picked from commit ec18759b1833e6c3593d99e96144659a32f9d0e8)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers