Blocks that have override_instance_title() don't need to record their title in block_instance table

Bug #1750925 reported by Robert Lyon on 2018-02-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Unassigned

Bug Description

I was gettign confused when I saw '[[title/blocktype.myviews]]' being saved and was not seeing the broken string on the frontend.

I'll make a patch to clean that all up

Robert Lyon (robertl-9) on 2018-02-21
Changed in mahara:
status: New → In Progress
importance: Undecided → Low
milestone: none → 18.04.0

Reviewed: https://reviews.mahara.org/8538
Committed: https://git.mahara.org/mahara/mahara/commit/d374ec0bfb3492d463e4b3c17641e3d8e9e0dea0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit d374ec0bfb3492d463e4b3c17641e3d8e9e0dea0
Author: Robert Lyon <email address hidden>
Date: Thu Feb 22 11:18:42 2018 +1300

Bug 1750925: Tidy up database for blocks that set their title via plugin

The 'myviews', 'mygroups', 'myfriends', 'wall' blocks all set their
title via the plugin so we don't need to set their title in
block_instance table.

Currently we are saving the 'myviews' one with broken lang string title

behatnotneeded

Change-Id: Ie583678e2a1bb650513f873024f49269b6e66912
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers