Mahara

Code correction in function find_key_name of lib/ddl.php

Bug #1749403 reported by Alexander Del Ponte
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
Mahara 18.04.0
18.04
Fix Released
Medium
Unassigned
Mahara 18.04.0
18.10
Fix Released
Medium
Unassigned
Mahara 18.10.0

Bug Description

In line 523 the existing code

if (!$field == $col->column_name) {

should be replaced with

if ($field !== $col->column_name) {

Greetings
Alex

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8663

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Still to be decided if it needs to be backported.

Changed in mahara:
milestone: none → 18.10.0
importance: Undecided → Medium
status: New → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8663
Committed: https://git.mahara.org/mahara/mahara/commit/82bc31a76370da50695fa86f2e8f8662998f9482
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 82bc31a76370da50695fa86f2e8f8662998f9482
Author: Alexander Del Ponte <email address hidden>
Date: Mon Mar 19 17:34:42 2018 +1300

Bug 1749403: Code correction in function find_key_name of lib/ddl.php

behatnotneeded

Change-Id: Iafa9250163ffea5e7d9902ad0e2a6c96f734c3b8

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8676

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8676
Committed: https://git.mahara.org/mahara/mahara/commit/dc8c7c30b3273da3973975e3c9fb35925454e7e8
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit dc8c7c30b3273da3973975e3c9fb35925454e7e8
Author: Alexander Del Ponte <email address hidden>
Date: Mon Mar 19 17:34:42 2018 +1300

Bug 1749403: Code correction in function find_key_name of lib/ddl.php

behatnotneeded

Change-Id: Iafa9250163ffea5e7d9902ad0e2a6c96f734c3b8
(cherry picked from commit 82bc31a76370da50695fa86f2e8f8662998f9482)

Revision history for this message
Alexander Del Ponte (delponte) wrote :

This bug also affects 17.10 and earlier.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.