Change what is reported in 'Latest changes I can view' and considered for mtime

Bug #1749039 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Doris Tam

Bug Description

If we
- have a collection of views
- edit the access of a views in shared by me page
- edit the access of a view from the view edit page

The last modified time of the view does not update.

Changing a view's access is a modification of the view in the sense that more/less people can see the view.

We need to update the view's mtime to the same date as the view access ctime.

Not doing so causes problems for advanced reporting where we find things via viewaccess time but display view mtime

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

This actually needs to be fixed for any view, regardless of whether they are in a collection.

We need to update view's mtime when updating its access, that means when:

- a new secret url is added/modified/deleted
- view is shared, stop being shared, or modified shared with different sets of groups (Share with Public, Friends, Groups, ..)

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

There are other places to check how we update the modified view time, this is what I found through testing:
- Adding a block to a page changes the mtime of the view table, deleting a block does not
- Adding/deleting a tag to the page changes the mtime of the view table
- Adding/deleting a comment to the page updates the mtime of the view table

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Cecilia, please add the details of what we discussed and agreed on to change. Thank you. :-)

no longer affects: mahara/18.04
no longer affects: mahara/18.10
no longer affects: mahara/19.04
no longer affects: mahara/19.10
Changed in mahara:
milestone: 19.04.1 → 20.04.0
Changed in mahara:
milestone: 20.04.0 → 20.10.0
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Decision on when mtime update should be visible.

Premise: Make updates visible when content changes have been made. Metadata changes, access, or editing changes are not relevant.

This means in particular: When is a page displayed again as having been updated in the 'Latest changes I can view' block and moved to the front on 'Pages and collections' when in chronological view.

The original advanced reporting issue has been considered as part of this.

summary: - Updating view access does not update view mtime even though changing
- access is a change to the view
+ Change what is reported in 'Latest changes I can view' and considered
+ for mtime
Changed in mahara:
milestone: 20.10.0 → 21.04.0
Changed in mahara:
milestone: 21.04.0 → 21.10.0
Changed in mahara:
assignee: Cecilia Vela Gurovic (ceciliavg) → nobody
status: In Progress → Confirmed
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 21.10.0 → 22.04.0
Doris Tam (doristam)
Changed in mahara:
assignee: nobody → Doris Tam (doristam)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12334

Changed in mahara:
status: Confirmed → In Progress
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers