"Inactive user" highlight disappeared

Bug #1748782 reported by Kristina Hoeppner on 2018-02-11
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Liam
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Liam

Bug Description

In Mahara 16.10 we added the functionality to show inactive users in Admin -> Users -> User search. See the user manual at http://manual.mahara.org/en/16.10/administration/users.html#index-4 (#16 in the screenshot).

This disappeared in Mahara 17.04. It needs to be put back in.

The functionality was added in https://reviews.mahara.org/#/c/6631

The code is still there, but it seems that it is not passed to the template. Please have a chat with Robert if you have questions, Liam. Thank you.

description: updated

Reviewed: https://reviews.mahara.org/8557
Committed: https://git.mahara.org/mahara/mahara/commit/6b8396d683837312f11112b5034d9932bd6f1984
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 6b8396d683837312f11112b5034d9932bd6f1984
Author: Robert Lyon <email address hidden>
Date: Fri Mar 2 09:31:02 2018 +1300

Bug 1748782: Fix clash of 'active' values in user search results

We were confusing user active with auth active values from db call
So changed the auth 'active' to 'authactive'

Also add warning message to top of admin/users/edit.php page to
indicate that user has expired (similar to when user is suspended)

behatnotneeded

Change-Id: I437665cffa6f2d372ef4c5c39fad7bec183e3a2d
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8573

Reviewed: https://reviews.mahara.org/8572
Committed: https://git.mahara.org/mahara/mahara/commit/efd06c9a58bd5c13385fb42de5cc1b7aadb734b5
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit efd06c9a58bd5c13385fb42de5cc1b7aadb734b5
Author: Robert Lyon <email address hidden>
Date: Fri Mar 2 09:31:02 2018 +1300

Bug 1748782: Fix clash of 'active' values in user search results

We were confusing user active with auth active values from db call
So changed the auth 'active' to 'authactive'

Also add warning message to top of admin/users/edit.php page to
indicate that user has expired (similar to when user is suspended)

behatnotneeded

Change-Id: I437665cffa6f2d372ef4c5c39fad7bec183e3a2d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6b8396d683837312f11112b5034d9932bd6f1984)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8573
Committed: https://git.mahara.org/mahara/mahara/commit/8e6c286bbafe723f044cea1e4d5d10f501b76fbc
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 8e6c286bbafe723f044cea1e4d5d10f501b76fbc
Author: Robert Lyon <email address hidden>
Date: Fri Mar 2 09:31:02 2018 +1300

Bug 1748782: Fix clash of 'active' values in user search results

We were confusing user active with auth active values from db call
So changed the auth 'active' to 'authactive'

Also add warning message to top of admin/users/edit.php page to
indicate that user has expired (similar to when user is suspended)

behatnotneeded

Change-Id: I437665cffa6f2d372ef4c5c39fad7bec183e3a2d
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 6b8396d683837312f11112b5034d9932bd6f1984)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers