missing help file Site options/Account settings

Bug #1742354 reported by Cecilia Vela Gurovic on 2018-01-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Cecilia Vela Gurovic

Bug Description

As a site admin user, in Site options-> account settings -> Override user account lifetime
when clicking the 'i' icon to get help info, we get an error "An error occurred trying to retrieve the help page."

This happens because the htdocs/lang/en.utf8/help/forms/siteoptions.defaultaccountlifetimeupdate.html that contains the help description is missing.

Robert Lyon (robertl-9) on 2018-01-11
Changed in mahara:
milestone: none → 18.04.0
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
importance: Undecided → Medium
status: New → Confirmed

For the Override user account lifetime field we have the values it can take and a description at the bottom:
"If default account lifetime is set, then choose how to deal with user expiry times."

do we still need an extra help description?

for more information about this field see bug#1097565

Robert Lyon (robertl-9) wrote :

Yeah it was an oversight when I made the patch - I suspect I copied/pasted from another setting that had help = true

It doesn't need the help icon so will remove

Changed in mahara:
status: Confirmed → In Progress

Reviewed: https://reviews.mahara.org/8594
Committed: https://git.mahara.org/mahara/mahara/commit/cdc14d8839b07eafd33fe08e37a4b9ce7de80507
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cdc14d8839b07eafd33fe08e37a4b9ce7de80507
Author: Robert Lyon <email address hidden>
Date: Thu Mar 8 12:05:36 2018 +1300

Bug 1742354: removing help icon for Override user account lifetime

In Admin -> Site options-> account settings

As the description is enough

behatnotneeded

Change-Id: Ib50d328c5f127f7f0f816392b21e2e490fd410e6
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9) on 2018-03-08
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers