External(Kaltura) video doesn't play when block is on auto-retract

[albifeduni]

Hi,
This one is similar to bug report - Bug #1565669
Embedded Kaltura video in Mahara not displaying when the setting retractable is set to Automatically retract.
The video will play when set to Retractable=Yes or Retractable=No.

This one is similar to bug report - Bug #1565669

Example Embed:
<iframe id="kaltura_player" src="https://cdnapisec.kaltura.com/p/2246991/sp/224699100/embedIframeJs/uiconf_id/38197461/partner_id/2246991?iframeembed=true&playerId=kaltura_player&entry_id=0_t2juqhe6&flashvars[streamerType]=auto&amp;flashvars[localizationCode]=en&amp;flashvars[leadWithHTML5]=true&amp;flashvars[sideBarContainer.plugin]=true&amp;flashvars[sideBarContainer.position]=left&amp;flashvars[sideBarContainer.clickToClose]=true&amp;flashvars[chapters.plugin]=true&amp;flashvars[chapters.layout]=vertical&amp;flashvars[chapters.thumbnailRotator]=false&amp;flashvars[streamSelector.plugin]=true&amp;flashvars[EmbedPlayer.SpinnerTarget]=videoHolder&amp;flashvars[dualScreen.plugin]=true&amp;&wid=0_lp5uyok9" width="400" height="285" allowfullscreen webkitallowfullscreen mozAllowFullScreen frameborder="0" title="Kaltura Player"></iframe>

[Robert Lyon (robertl-9)]

The problem with Kaltura videos in automatically retracted blocks looks to be related to the external javascript from Kaltura the Mahara block fetches to render the video.

The Mahara block sets up some video information on page load
 - but when the block is auto retracted it seems the video player knows it is not 'visible' on page and so fails to load some info.

I get this error: embedPlayer.kalturaPlayerMetaData is null

We probably need to alter how we load/start the Kaltura video and do it in a more controlled way. Possibly using the info here http://player.kaltura.com/docs/index.php?path=kwidget so that we can load the video on either page load or when a button is clicked (in this case when we expand the collapsed block)

[Rob Hardy (r-hardy)]

This may be related to an issue we have found with Medial Media Library.

The issue I found is that ampersands appear to always be being encoded as HTML entities when written into the page (i.e. & becomes &amp;) - I presume this is a feature of the Smarty templating engine, as I can see the ampersands in the URLs are not encoded in the database, nor when they are assigned to the template. This doesn't cause an issue when the (iframe-based) embed code is written directly into the HTML of the page, as it is when Retract is set to "Yes" or "No".

However, when the block is set to "Automatically retract", the embed code is loaded from a jQuery function when the block header is clicked. The ampersands are encoded when this function is written into the page, but jQuery appears to be re-encoding the ampersands (so that &amp; becomes &amp;amp;). This is visible once the video is loaded, by inspecting via Firefox web developer tools, and using "Edit as HTML".

At the moment, the only fix I've found for this feels a bit hacky: to use a JavaScript replace() to decode the ampersands before they are passed to the onclick handler (see attached patch).

[Rob Hardy (r-hardy)]

Patch for htdocs/theme/raw/plugintype/blocktype/externalvideo/templates/content.tpl

[Kristina Hoeppner (kris-hoeppner)]

Thank you, Rob, for the patch. We'll put it into our code review system https://reviews.mahara.org

If you'd like to be able to push any future changes to code review directly, you can find information on how to set up an account and your dev environment at https://wiki.mahara.org/wiki/Developer_Area/Contributing_Code

Cheers
Kristina

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8775

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8775
Committed: https://git.mahara.org/mahara/mahara/commit/c511a88b57ba18bbe4021d593657c54cf6fbacf0
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c511a88b57ba18bbe4021d593657c54cf6fbacf0
Author: Rob Hardy <email address hidden>
Date: Wed Apr 4 17:03:51 2018 +1200

Bug 1742349: External(Kaltura) video doesn't play when block is on auto-retract

behatnotneeded

Change-Id: I696cc21372d878616e5111f6f1a7ecf30398b557