Elasticsearch not updating indexed items when access rules change
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
16.10 |
Fix Released
|
High
|
Unassigned | ||
17.04 |
Fix Released
|
High
|
Unassigned | ||
17.10 |
Fix Released
|
High
|
Unassigned | ||
18.04 |
Fix Released
|
High
|
Robert Lyon |
Bug Description
When a page has it's access rules changed (but not other editing) the elasticsearch does not update the index for the items involved.
There is an add_to_
But that is not quite sufficient.
Problems:
1) If a page is indexed and then later it's access rules are changed the page and it;s artefacts/blocks were not getting re-indexed to reflect the rule change
- need the add_to_
2) If a page did get found with the add_to_
- need to add a sql query to find these non-artefact items we want to index and them to the queue also
3) Deleting of all the view_access rules for a page was not being picked up and so items
were not being re-indexed
- need to add items to queue when all access rules are removed from a view
[this is not a problem if rules are changed as we delete all rules and add in new ones so can be picked up by change for (1) where we look for new access rules]
Changed in mahara: | |
importance: | Undecided → High |
status: | New → In Progress |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 18.04.0 |
Reviewed: https:/ /reviews. mahara. org/8370 /git.mahara. org/mahara/ mahara/ commit/ f41ec4dbcd000b5 57ecbc07cff57d1 ec9307af67
Committed: https:/
Submitter: Robert Lyon (<email address hidden>)
Branch: master
commit f41ec4dbcd000b5 57ecbc07cff57d1 ec9307af67
Author: Robert Lyon <email address hidden>
Date: Tue Dec 19 10:37:02 2017 +1300
Bug 1738898: Elasticsearch not indexing access changes correctly
There is an add_to_ queue_access( ) function that is meant to check what
pages have had their access changed since they were indexed. It was
designed to catch the pages which have a start/stop date.
But that is not quite sufficient.
See bug report for more info
behatnotneeded
Change-Id: I160d074fc709c7 e94c9c4cacab8f2 c5e6c7e9a86
Signed-off-by: Robert Lyon <email address hidden>