Legacy code passes around a $new value when creating a new page but it is not needed
Bug #1738303 reported by
Robert Lyon
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mahara |
Fix Released
|
Medium
|
Unassigned | ||
Bug Description
We only need the $new variable on the editlayout.php page because after that the view exists in db and so we can just display it's real title rather than 'No title'
| Changed in mahara: | |
| milestone: | none → 18.04.0 |
| status: | New → In Progress |
| importance: | Undecided → Medium |
Revision history for this message
| Mahara Bot (dev-mahara) wrote A change has been merged | #1 |
| Changed in mahara: | |
| status: | In Progress → Fix Committed |
| Changed in mahara: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Reviewed: https:/
Committed: https:/
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master
commit fef8c68dbdc9754
Author: Robert Lyon <email address hidden>
Date: Fri Dec 15 13:13:34 2017 +1300
Bug 1738303: Remove the obsolete $new variable being passed about when
creating a new page.
It is mostly so we can show 'No title' for page name and to have a
'back' button instead of 'edit page' when viewing ones own page.
But we don't need it as a page has a title when we click 'add page' as
we make the new view entry in database straight away and the title
will be something like 'Untitled v.2'.
And if we change the title on page settings form then block edit screen
will now show new correct title instead of 'No title'
behatnotneeded
Change-Id: I4630d53fbee734
Signed-off-by: Robert Lyon <email address hidden>