Legacy code passes around a $new value when creating a new page but it is not needed

Bug #1738303 reported by Robert Lyon on 2017-12-15
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

We only need the $new variable on the editlayout.php page because after that the view exists in db and so we can just display it's real title rather than 'No title'

Robert Lyon (robertl-9) on 2017-12-15
Changed in mahara:
milestone: none → 18.04.0
status: New → In Progress
importance: Undecided → Medium

Reviewed: https://reviews.mahara.org/8364
Committed: https://git.mahara.org/mahara/mahara/commit/fef8c68dbdc97545c6da83e19d560cccc85d034f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit fef8c68dbdc97545c6da83e19d560cccc85d034f
Author: Robert Lyon <email address hidden>
Date: Fri Dec 15 13:13:34 2017 +1300

Bug 1738303: Remove the obsolete $new variable being passed about when
creating a new page.

It is mostly so we can show 'No title' for page name and to have a
'back' button instead of 'edit page' when viewing ones own page.

But we don't need it as a page has a title when we click 'add page' as
we make the new view entry in database straight away and the title
will be something like 'Untitled v.2'.

And if we change the title on page settings form then block edit screen
will now show new correct title instead of 'No title'


Change-Id: I4630d53fbee734f1f4e903c05aa92b8348f3f41f
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers