Unable to view public group homepage when logged out

Bug #1737851 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
17.10
Fix Released
High
Unassigned
18.04
Fix Released
High
Unassigned

Bug Description

When we have the follow in play:

1) A group that has "public" = 1
2) a group homepage where the group pages block has $configdata['showsubmitted'] = 1

When a logged out user tries to view the group homepage we get an error:

group_user_access: user argument should be an integer

This is because the logged out user can't be compared to a group member/admin

We need to add a $USER->is_logged-in() check before going down that rabbithole

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8348

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8348
Committed: https://git.mahara.org/mahara/mahara/commit/1cbf546387e28cbae16dddbfb97472ceeda47a40
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 1cbf546387e28cbae16dddbfb97472ceeda47a40
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 12:36:31 2017 +1300

Bug 1737851: Avoid submitted list check for loggedout user

When viewing a public group

behatnotneeded

Change-Id: I71a55f6bea018969a8499ca04d9c57754aa9a0de
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8349

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8349
Committed: https://git.mahara.org/mahara/mahara/commit/f2824987f054f8d492536b8cfd12cd95ea1a8d24
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit f2824987f054f8d492536b8cfd12cd95ea1a8d24
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 12:36:31 2017 +1300

Bug 1737851: Avoid submitted list check for loggedout user

When viewing a public group

behatnotneeded

Change-Id: I71a55f6bea018969a8499ca04d9c57754aa9a0de
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 1cbf546387e28cbae16dddbfb97472ceeda47a40)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.