Add a spinner icon when copying collections

Bug #1737581 reported by David Ligne on 2017-12-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Unassigned

Bug Description

Copying a collection can take some time. Even before bug 1724603, it could take more than 30 seconds.
During that time, some users think it isn't working and try and try again, resulting in several collection copies they will have to delete after. It can be very tedious since they have to delete the pages too. We've had some complaints about that.

Adding a spinner icon or at least a message could prevent this kind of situation.

Robert Lyon (robertl-9) wrote :

Hi David,

We do have some code that does what you mention but for some reason it is not hooked up to that form.

I'll make a patch to fix that

Cheers

Robert

Changed in mahara:
milestone: none → 18.04.0
importance: Undecided → High
status: New → In Progress

Reviewed: https://reviews.mahara.org/8344
Committed: https://git.mahara.org/mahara/mahara/commit/84ee402ce229f257c0de2ca62cf02352fc572b39
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 84ee402ce229f257c0de2ca62cf02352fc572b39
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 09:33:04 2017 +1300

Bug 1737581: Disable copy collection button after first click

To stop user clicking the button multiple times thinking it didn't
work the first time. This is via the 'Copy' button within the
collection.

Also fix up the changing of button to 'processing ...' and showing the
spinner when copying collection/page on 'Copy page or collection' page

behatnotneeded

Change-Id: I4188abded7135f6722c679114b8299a92dfbf2aa
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/8357
Committed: https://git.mahara.org/mahara/mahara/commit/849b0be2bdc38f28773b48dd48185597c56a7a90
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 849b0be2bdc38f28773b48dd48185597c56a7a90
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 09:33:04 2017 +1300

Bug 1737581: Disable copy collection button after first click

To stop user clicking the button multiple times thinking it didn't
work the first time. This is via the 'Copy' button within the
collection.

Also fix up the changing of button to 'processing ...' and showing the
spinner when copying collection/page on 'Copy page or collection' page

behatnotneeded

Change-Id: I4188abded7135f6722c679114b8299a92dfbf2aa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 84ee402ce229f257c0de2ca62cf02352fc572b39)

Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8362

Reviewed: https://reviews.mahara.org/8360
Committed: https://git.mahara.org/mahara/mahara/commit/65f503b0bfb35169491ccc42bd9d5b5645727779
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 65f503b0bfb35169491ccc42bd9d5b5645727779
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 09:33:04 2017 +1300

Bug 1737581: Disable copy collection button after first click

To stop user clicking the button multiple times thinking it didn't
work the first time. This is via the 'Copy' button within the
collection.

Also fix up the changing of button to 'processing ...' and showing the
spinner when copying collection/page on 'Copy page or collection' page

behatnotneeded

Change-Id: I4188abded7135f6722c679114b8299a92dfbf2aa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 84ee402ce229f257c0de2ca62cf02352fc572b39)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8362
Committed: https://git.mahara.org/mahara/mahara/commit/08a3d700185b22a3ce1ac6e156cbbd97d4de64f5
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 08a3d700185b22a3ce1ac6e156cbbd97d4de64f5
Author: Robert Lyon <email address hidden>
Date: Wed Dec 13 09:33:04 2017 +1300

Bug 1737581: Disable copy collection button after first click

To stop user clicking the button multiple times thinking it didn't
work the first time. This is via the 'Copy' button within the
collection.

Also fix up the changing of button to 'processing ...' and showing the
spinner when copying collection/page on 'Copy page or collection' page

behatnotneeded

Change-Id: I4188abded7135f6722c679114b8299a92dfbf2aa
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 84ee402ce229f257c0de2ca62cf02352fc572b39)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers