Show site and institution privacy statements in footer when an institution member is logged in

[Kristina Hoeppner]

We are going to change the way our privacy statement are displayed due to necessary changes for the GDPR.

For that, we should ensure that the link to the privacy statement in the footer of the site (if displayed) shows both site and institution privacy statements when an institution member is logged in.

[Robert Lyon (robertl-9)]

This will need to be configured via the footer_menu() function and the admin/site/menu.php 'Footer menu' section for T&C will need to be duplicated for the Institution section.

And also adjusted so that we a toggle for 'Show institution only / Show both site and institution'

[Kristina Hoeppner (kris-hoeppner)]

I think we'll always need to show the site T&C and institution T&C when an institution has separate ones as there are some T&C for the site that will apply to everyone. Therfore, I don't think we'll need a toggle.

If we require people to accept the T&C (set "Registration agreement" in the "General settings" in the "Site options" to "Yes"), it should not be possible to link to T&C that are not hosted on Mahara, i.e. remove the empty line where we can link somewhere else than a Mahara page.

[Kristina Hoeppner (kris-hoeppner)]

Changed the description to reference "privacy statement" as that is the immediate item we'll need to work on. Changing the T&C infrastructure can come at a later stage.

There is an item at bug #1739561 to remove the possibility to link to external T&C and privacy statement.

The revised privacy statement should have two sections:

1. Site statement
2. Institution statement.

If we are re-using this page to display elsewhere, it might be good if these two sections were in panels that can be closed.

[Cecilia Vela Gurovic (ceciliavg)]

When a user is logged in the 'Privacy statement' link in the footer should go to
/account/userprivacy.php

when no user is logged in then it should go to
/privacy.php

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8422

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8422
Committed: https://git.mahara.org/mahara/mahara/commit/87e8185cb7b01dc554a6e906632dfdaccb5431e2
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 87e8185cb7b01dc554a6e906632dfdaccb5431e2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Jan 11 17:11:29 2018 +1300

Bug 1736033: change privacy footer link for logged in user

When a user is logged in the 'Privacy statement' link in the footer should go to
/account/userprivacy.php

when no user is logged in then it should go to
/privacy.php

behatnotneeded

Change-Id: Ic0ded32c71a2f4e0f2238559c4c8a3fb0269f5b9