Problem with watchlist for a page

Bug #1735585 reported by Robert Lyon on 2017-12-01
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Robert Lyon

Bug Description

Currently when a person adds a page to their watchlist and then later they or someone else views (but not changes) the page a row is added to the watchlist queue this is because we fire off the 'saveartefact' event on page viewing

We should only fire the saveartefact event if actually changing something

Robert Lyon (robertl-9) on 2017-12-01
Changed in mahara:
importance: Undecided → High
status: New → In Progress
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 18.04.0

Reviewed: https://reviews.mahara.org/8322
Committed: https://git.mahara.org/mahara/mahara/commit/b335fdb79305dfe9a8f07eb04076e86d45da8ded
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b335fdb79305dfe9a8f07eb04076e86d45da8ded
Author: Robert Lyon <email address hidden>
Date: Fri Dec 1 14:24:17 2017 +1300

Bug 1735585: Fixing update of atime on page view

Currently we have a mahara_log function that logs page visits
So I decided we also need a mahara_touch_record($table, $id) function
that updates the 'atime' for a record when called

behatnotneeded

Change-Id: I2f645c8357426112f9edcdd24f1b8b85513cb7cb
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8336

Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8337

Reviewed: https://reviews.mahara.org/8336
Committed: https://git.mahara.org/mahara/mahara/commit/4974a91516d434072515d96de88e2e1acd008050
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 4974a91516d434072515d96de88e2e1acd008050
Author: Robert Lyon <email address hidden>
Date: Fri Dec 1 14:24:17 2017 +1300

Bug 1735585: Fixing update of atime on page view

Currently we have a mahara_log function that logs page visits
So I decided we also need a mahara_touch_record($table, $id) function
that updates the 'atime' for a record when called

behatnotneeded

Change-Id: I2f645c8357426112f9edcdd24f1b8b85513cb7cb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b335fdb79305dfe9a8f07eb04076e86d45da8ded)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8335
Committed: https://git.mahara.org/mahara/mahara/commit/c7e57c7408c9fb128b678c1e8b245f339d17b721
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit c7e57c7408c9fb128b678c1e8b245f339d17b721
Author: Robert Lyon <email address hidden>
Date: Fri Dec 1 14:24:17 2017 +1300

Bug 1735585: Fixing update of atime on page view

Currently we have a mahara_log function that logs page visits
So I decided we also need a mahara_touch_record($table, $id) function
that updates the 'atime' for a record when called

behatnotneeded

Change-Id: I2f645c8357426112f9edcdd24f1b8b85513cb7cb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b335fdb79305dfe9a8f07eb04076e86d45da8ded)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8337
Committed: https://git.mahara.org/mahara/mahara/commit/3dd6320f49b0addf0adf7524c7fcda7041b2d40f
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 3dd6320f49b0addf0adf7524c7fcda7041b2d40f
Author: Robert Lyon <email address hidden>
Date: Fri Dec 1 14:24:17 2017 +1300

Bug 1735585: Fixing update of atime on page view

Currently we have a mahara_log function that logs page visits
So I decided we also need a mahara_touch_record($table, $id) function
that updates the 'atime' for a record when called

behatnotneeded

Change-Id: I2f645c8357426112f9edcdd24f1b8b85513cb7cb
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b335fdb79305dfe9a8f07eb04076e86d45da8ded)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers