Buttons w/ white background are invisible in the configurable theme

Bug #1735442 reported by Kristina Hoeppner on 2017-11-30
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned
18.04
High
Unassigned

Bug Description

This is a regression to an earlier version of Mahara.

When you choose a white header background in the configurable theme, the button color turns white and doesn't have a border.

We used to have a border around it though so that the buttons can be seen.

Robert Lyon (robertl-9) wrote :

The commit 5e15470d8b3619772857c4205644c0677ef30a92 made the border in custom theme go from light grey to transparent.

This was fine when header background colour was dark as the button stood out from white page.

But with very light header background value the button disappears into the background.

Have made the button's border colour be the same as the header text colour

Reviewed: https://reviews.mahara.org/8341
Committed: https://git.mahara.org/mahara/mahara/commit/9280e348f18f2af6080fe5c3c53ec45317144fc7
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 9280e348f18f2af6080fe5c3c53ec45317144fc7
Author: Robert Lyon <email address hidden>
Date: Tue Dec 12 13:55:17 2017 +1300

Bug 1735442: Primary buttons in custom theme need border

Before it was transparent, which was fine when header background
colour was dark. But when it is light, eg white, then we can't see
where the button finishes and the page start.

Have made the border the same colour as text of button.

To test: re-save custom theme for institution with some actual change
so system saves new info

behatnotneeded

Change-Id: I925599d51d1c3446700c5439c1aeffda1383d150
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8356

Reviewed: https://reviews.mahara.org/8355
Committed: https://git.mahara.org/mahara/mahara/commit/aa720feb11c7b3cf74bf6413ff66940a977284dd
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit aa720feb11c7b3cf74bf6413ff66940a977284dd
Author: Robert Lyon <email address hidden>
Date: Tue Dec 12 13:55:17 2017 +1300

Bug 1735442: Primary buttons in custom theme need border

Before it was transparent, which was fine when header background
colour was dark. But when it is light, eg white, then we can't see
where the button finishes and the page start.

Have made the border the same colour as text of button.

To test: re-save custom theme for institution with some actual change
so system saves new info

behatnotneeded

Change-Id: I925599d51d1c3446700c5439c1aeffda1383d150
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9280e348f18f2af6080fe5c3c53ec45317144fc7)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8356
Committed: https://git.mahara.org/mahara/mahara/commit/4fcadff5b94af015694b6715d1dbc54bc9971cf3
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 4fcadff5b94af015694b6715d1dbc54bc9971cf3
Author: Robert Lyon <email address hidden>
Date: Tue Dec 12 13:55:17 2017 +1300

Bug 1735442: Primary buttons in custom theme need border

Before it was transparent, which was fine when header background
colour was dark. But when it is light, eg white, then we can't see
where the button finishes and the page start.

Have made the border the same colour as text of button.

To test: re-save custom theme for institution with some actual change
so system saves new info

behatnotneeded

Change-Id: I925599d51d1c3446700c5439c1aeffda1383d150
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9280e348f18f2af6080fe5c3c53ec45317144fc7)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers