Elasticsearch results not displayed when on paginated page

Bug #1735256 reported by Robert Lyon on 2017-11-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned
17.10
Medium
Unassigned

Bug Description

Problem: When doing a subsequent search in elasticsearch after paginating to non first page of initial results. If the new results are greater than 0 but less than 10 no results are displayed but the tab indicates results exist.

To test:
1) On a site with elasticsearch enabled and indexed - first do full search (by leaving search field blank) and have more than 10 results in 'Text' tab
2) Go to page 2 of the results
3) Now search again using search field above tabs (NOT the one at top of page) for something that appears in 'Text' tab only a few times, eg country for user
4) Should display count in 'Text' tab but not the actual result.

This is due to the ajax call not setting 'offset' back to 0 for the pagination

Reviewed: https://reviews.mahara.org/8319
Committed: https://git.mahara.org/mahara/mahara/commit/71d1c2df2112350b1396489b3a0dbc149e928b3b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 71d1c2df2112350b1396489b3a0dbc149e928b3b
Author: Robert Lyon <email address hidden>
Date: Thu Nov 30 08:29:07 2017 +1300

Bug 1735256: Make sure pagination offset is reset on new search

In the elasticsearch results page when using the search box on that page

behatnotneeded

Change-Id: I1b6fa028c5456623dd656b99b0263ed9a28748dd
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/8324
Committed: https://git.mahara.org/mahara/mahara/commit/2aa531806bc1ed05004096d1a861604c1ee22951
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 2aa531806bc1ed05004096d1a861604c1ee22951
Author: Robert Lyon <email address hidden>
Date: Thu Nov 30 08:29:07 2017 +1300

Bug 1735256: Make sure pagination offset is reset on new search

In the elasticsearch results page when using the search box on that page

behatnotneeded

Change-Id: I1b6fa028c5456623dd656b99b0263ed9a28748dd
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 71d1c2df2112350b1396489b3a0dbc149e928b3b)

Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers