images not displayed in shared page in tagged journal entries element

Bug #1732848 reported by Cyle Sprick on 2017-11-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 18.04
17.10
High
Unassigned
18.04
High
Robert Lyon

Bug Description

A journal entry with an inline image or an attachment is displayed on a page with a 'tagged journal entries' element.
The page is shared with others (group or individual) and the images (or attachments) are not displayed to the share-e.
Linked images (from another url) are displayed correctly.

Cyle Sprick (csprick) wrote :

More info...images in text elements, image elements, journal elements and journal entry elements are all shown fine. Only the "tagged journal entries" element seems to have this problem.

Thanks for the report. This seems to be a regression in Mahara 17.10 as I can see an image in 17.04.

Note for replication: The items need to be shown in full on the page in order to see the problem.

tags: added: regression

Reviewed: https://reviews.mahara.org/8294
Committed: https://git.mahara.org/mahara/mahara/commit/dfee04b09a0f5443192ab6dbe3fbe2d2b3cb5e39
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit dfee04b09a0f5443192ab6dbe3fbe2d2b3cb5e39
Author: Robert Lyon <email address hidden>
Date: Tue Nov 21 12:28:57 2017 +1300

Bug 1732848: Allow the taggedpost image url to include the view id

Because we are not using the normal generated html for rendering a
blog post we need to filter the description text so that any embedded
images include the view id

We also need to add the attachments html directly as well so need to
move that to it's own template

behatnotneeded

Change-Id: If6df01ec217610849108b599adfc04b81fd10b66
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/8358
Committed: https://git.mahara.org/mahara/mahara/commit/76909b6feb9b6d410e1ed34f2ec346485b7f8bf2
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 76909b6feb9b6d410e1ed34f2ec346485b7f8bf2
Author: Robert Lyon <email address hidden>
Date: Tue Nov 21 12:28:57 2017 +1300

Bug 1732848: Allow the taggedpost image url to include the view id

Because we are not using the normal generated html for rendering a
blog post we need to filter the description text so that any embedded
images include the view id

We also need to add the attachments html directly as well so need to
move that to it's own template

behatnotneeded

Change-Id: If6df01ec217610849108b599adfc04b81fd10b66
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit dfee04b09a0f5443192ab6dbe3fbe2d2b3cb5e39)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers