Need to consolidate country code information for Mahara 18.04.0

Bug #1732046 reported by Robert Lyon on 2017-11-13
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Medium
Unassigned

Bug Description

Currently we have lib/country.php containing the 'Country' class which list the 2 and 3 char codes
And we have getoptions_country() in lib/web.php that list the 2 char codes

We don't need both - we should make the Country class the preferred one and fetch our 2 char codes for getoptions_country() from the class.

Robert Lyon (robertl-9) on 2017-11-13
Changed in mahara:
status: New → In Progress
importance: Undecided → Medium
milestone: none → 18.04.0
summary: - Need to consolidate country code information
+ Need to consolidate country code information for Mahara 18.04.0

Reviewed: https://reviews.mahara.org/8277
Committed: https://git.mahara.org/mahara/mahara/commit/3b64fa1f862b9fdf3b6a72c8d7a0320d6202ac81
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 3b64fa1f862b9fdf3b6a72c8d7a0320d6202ac81
Author: Robert Lyon <email address hidden>
Date: Tue Nov 14 11:48:00 2017 +1300

Bug 1732046: Fixing up the country codes within country lib file

Fixing some mistakes from Bug 1514647 where we forgot to update the
Country class, which is used as part of the import/export leap2A process

Also adjusting getoptions_country() so that it fetches the 2 char
codes from the Country class rather than repeating code.

behatnotneeded

Change-Id: I901e6a1827da31fbdbb1ac4c9fb8e46b247b5dc2
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers