Delete button style/placement inconsistent

Bug #1731330 reported by Robert Lyon on 2017-11-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Jaque
18.04
High
Jaque
18.10
High
Unassigned

Bug Description

For things that are editable/deletable we tend to have a convention of using a button group where the delete button is the right most button.

But in some places we have the delete button the left button and or we don't use the button group

Examples are:
- Admin -> Institution list page
- SmartEvidence list page

We should tidy this up to be more consistent as that will help with User experience

Robert Lyon (robertl-9) wrote :
Changed in mahara:
status: New → Confirmed

Spoke with one of our UX and she recommended to continue not showing the delete button when it's not needed. That would mean to have an empty button / icon so we can have the delete button on the right-hand side.

We should probably also change the Edit / Delete buttons in Web services -> Manage service groups / Manage service access tokens and remove the text there as we normally don't have text on these buttons. The edit button should turn into the gear icon which we normally use for settings pages.

tags: added: usermanualupdate
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
status: In Progress → Confirmed
assignee: Cecilia Vela Gurovic (ceciliavg) → nobody
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8638

Reviewed: https://reviews.mahara.org/8638
Committed: https://git.mahara.org/mahara/mahara/commit/4db927809f556db1656630c33023309360e44696
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4db927809f556db1656630c33023309360e44696
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Mar 16 13:18:35 2018 +1300

Bug 1731330: edit/delete buttons to btn-group style

Institution list Edit/delete buttons to be button group
in /admin/users/institutions.php

behatnotneeded

Change-Id: I775becf5c406e0892a5827b38a7a552845efec5c

Reviewed: https://reviews.mahara.org/8659
Committed: https://git.mahara.org/mahara/mahara/commit/b38fd178913b5a6894e6a84578d96d85d913aac1
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit b38fd178913b5a6894e6a84578d96d85d913aac1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Mar 16 13:18:35 2018 +1300

Bug 1731330: edit/delete buttons to btn-group style

Institution list Edit/delete buttons to be button group
in /admin/users/institutions.php

behatnotneeded

Change-Id: I775becf5c406e0892a5827b38a7a552845efec5c
(cherry picked from commit 4db927809f556db1656630c33023309360e44696)

Robert Lyon (robertl-9) wrote :

Still the smart evidence list page to do

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8571
Committed: https://git.mahara.org/mahara/mahara/commit/8f36bac92057da9442a647ed6c7ef1b848532e4f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8f36bac92057da9442a647ed6c7ef1b848532e4f
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 6 12:13:27 2018 +1300

Bug 1731330: edit/delete buttons to button group SE

Edit/delete buttons to be button group in SmarEvidence
matrix list
/module/framework/frameworks.php

behatnotneeded

Change-Id: Ib0b046d2ea6df155ea22876071660288129da9e1

Reviewed: https://reviews.mahara.org/8720
Committed: https://git.mahara.org/mahara/mahara/commit/488eb78facecbc98ccf1c2de5be8f0550b71098b
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 488eb78facecbc98ccf1c2de5be8f0550b71098b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Mar 6 12:13:27 2018 +1300

Bug 1731330: edit/delete buttons to button group SE

Edit/delete buttons to be button group in SmarEvidence
matrix list
/module/framework/frameworks.php

behatnotneeded

Change-Id: Ib0b046d2ea6df155ea22876071660288129da9e1
(cherry picked from commit 8f36bac92057da9442a647ed6c7ef1b848532e4f)

Robert Lyon (robertl-9) wrote :

There is also:

Journal entry list:
artefact/blog/view/index.php

The button group should be the tree buttons I recon

For this bug we only need to fix the buttons in Journal entry list:
artefact/blog/view/index.php

for each blog post we have 3 buttons: Unpublish, edit and delete (check image attached)
 - they are not properly align, the unpublish button is a bit higher than the rest
 - and the edit and delete buttons should have "button group" style: the right border of the edit button is rounded when it should be squared

these are all styling changes

Robert Lyon (robertl-9) wrote :

Note: the 'unpublish' button becomes 'publish' via javascript when you click it

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8752

Reviewed: https://reviews.mahara.org/8752
Committed: https://git.mahara.org/mahara/mahara/commit/9474fd7cb2fb4012df5523b78d20d31e00b7c109
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9474fd7cb2fb4012df5523b78d20d31e00b7c109
Author: Sarah Kirby <email address hidden>
Date: Wed Mar 28 14:15:03 2018 +1300

Bug 1731330: Style group edit delete buttons on

Journal and Institutions pages

behatnotneeded

Change-Id: I39885dc6791666b5cba190139962931d29cbb55b

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/8749
Committed: https://git.mahara.org/mahara/mahara/commit/0da0a83ce66eaa41a32fcec8c722c7a7aea0710c
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 0da0a83ce66eaa41a32fcec8c722c7a7aea0710c
Author: Sarah Kirby <email address hidden>
Date: Wed Mar 28 14:15:03 2018 +1300

Bug 1731330: Style group edit delete buttons on

Journal and Institutions pages

behatnotneeded

Change-Id: I39885dc6791666b5cba190139962931d29cbb55b

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers