wrong default option for personal information when importing

[Cecilia Vela Gurovic]

When importing a portfolio as Leap2A, there will be personal information contained in the XML file. After uploading the file, the personal information will be displayed with an option 'Ignore' or 'Replace' depending on whether the data in the XML matches or not with the logged in user's information.

This data is taken from the <author> tag in the xml, that is present in all exported XMLs, even in the ones that are created to export only one page. So any Leap2A import will by default replace the firstname, lastname and email of the user doing the import with the one in the XML, if the data is different (comes from another user's export).

The user doing the import can always change the option to 'Ignore' but this is not the ideal situation.

The way it should work:

In the case of importing a complete portfolio and the personal information contained in the XML is different than the logged in user, display it with default option = 'Replace'.
In the case of importing just a few pages/collections and the personal information contained in the XML is different than the logged in user, display it with default option = 'Ignore'.

[Kristina Hoeppner (kris-hoeppner)]

Forum discussion in which this was discovered: https://mahara.org/interaction/forum/topic.php?id=8077

[Kristina Hoeppner (kris-hoeppner)]

This is now happening:
In the case of importing a complete portfolio and the personal information contained in the XML is different than the logged in user, display it with default option = 'Replace'.

Still to do:

In the case of importing just a few pages/collections and the personal information contained in the XML is different than the logged in user, display it with default option = 'Ignore'.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11544

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11544
Committed: https://git.mahara.org/mahara/mahara/commit/9c37027068028a6198b97689ab9618a418825b5d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9c37027068028a6198b97689ab9618a418825b5d
Author: Gold <email address hidden>
Date: Wed Feb 10 11:03:10 2021 +1300

Bug 1730263 - Multiple sources for names in persondata

A partial export (just selected pages) does not include the persondata
tags. When these are not present the first/last names are taken from the
author tag. I've added a 'source' parameter to the firstname/lastname
fields that can be checked later in the process when the Import form is
being presented. If the source is the author tags we force the Ignore
option on the decision field values.

The Bug referenced 'personal information' so I have included the email
field.

Change-Id: Ifa173a88f497be994c5ab93e26376463442ab24b