Mahara logo is cut off at the bottom in IE 11

[Robert Lyon]

In IE the base of the Mahara logo is being hidden

I believe it is due to the fact that the image has a height of 45px but the container it is in is floated and so lacks height.

I tried adding 60px height to the containing <a> tag and it looked ok

Will make a patch so people can test

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8177

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8253

[Niranjan (niranjan528)]

URL: https://bugs.launchpad.net/mahara/+bug/1726655

Bug description: Mahara logo is cut off at the bottom in IE11.

Environment to be tested: Master
Browser to be tested: IE 11

Precondition:
The institution 'Institution A' exists and the user is a admin in that institution.

Steps to reproduce:

1. Open IE 11 and enter the URL to the Mahara instance.

Expected result: Mahara logo should be displayed properly without any
cut off.

2. Log in as ‘Institution admin’.

Expected result: Mahara logo should be displayed properly without any cut off.

3. Navigate to Administration menu > Institutions > Settings.
4. Click the ‘Settings’ button for ‘Institution A’.
5. Upload a logo and Click the ‘Submit’ button.
6. Log out and Log in back as ‘Institution admin’.

Expected result: Mahara logo should be displayed properly without any cut off.

7. Compare the Mahara logo with another browser and verify if the dimensions are aligned properly.

Expected result: Mahara logo should have the same dimensions as the other browser.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8177
Committed: https://git.mahara.org/mahara/mahara/commit/a65e3cd952dea467d1c2d899b88fb35d5601a96a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a65e3cd952dea467d1c2d899b88fb35d5601a96a
Author: Robert Lyon <email address hidden>
Date: Tue Oct 24 14:37:59 2017 +1300

Bug 1726655: Allow more space for logo in IE11

behatnotneeded

Change-Id: If68427764654a1f92df89453515ee2c3f710bb61
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8273

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8253
Committed: https://git.mahara.org/mahara/mahara/commit/79c2d745121a7fabf93acbf17399de6a2838ec39
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 79c2d745121a7fabf93acbf17399de6a2838ec39
Author: Pat Kira <email address hidden>
Date: Thu Nov 2 12:45:09 2017 +1100

Bug 1726655: Allow more space for logo in IE11

behatnotneeded

Change-Id: I9be88740d6e93297a7895156012b37314d706b75

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8273
Committed: https://git.mahara.org/mahara/mahara/commit/236a514ccd6f6550851e07be7f2a8c085ff3184b
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit 236a514ccd6f6550851e07be7f2a8c085ff3184b
Author: Robert Lyon <email address hidden>
Date: Tue Oct 24 14:37:59 2017 +1300

Bug 1726655: Allow more space for logo in IE11

behatnotneeded

Change-Id: If68427764654a1f92df89453515ee2c3f710bb61
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a65e3cd952dea467d1c2d899b88fb35d5601a96a)