SAML metadata page shouldn't redirect to main page when a site is in maintenance mode
Bug #1724743 reported by
Dmitrii Metelkin
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Cecilia Vela Gurovic |
Bug Description
SAML metadata page /auth/saml/
description: | updated |
Changed in mahara: | |
milestone: | none → 18.04.0 |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in mahara: | |
assignee: | nobody → Cecilia Vela Gurovic (ceciliavg) |
Changed in mahara: | |
status: | In Progress → Fix Committed |
tags: | added: nominatedfeature |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Around line 391 of init.php we check if site is closed for upgrade/maintenance mode and if so we logout the user and redirect them to homepage if not doing install/upgrade.
Where we check $USER-> is_logged_ in() on line 396 we could also check if the auth instance is an external vs internal auth type and reply with the correct HTTP response and/or json object saying access is not available if external auth type before logging them out and redirecting to hompage.