Edit plans more easily from a page

[Stacey Walker]

We have a client who has identified that end users of their Mahara installation need to be able to update a plan or task from within a blocktype instance and return to the page that they were on for more consistent experience.

Finding their way to the plan or task itself in their portfolio content can be several clicks to get to and then several more to return to the page or dashboard they were reviewing. This can also be exacerbated if the user has a high number of instances of each content or page type.

Because of the above they have required the following enhancements added to the Plans blocktype to improve user experience:

1. a link to edit a plan instance (description, title, tags etc)
2. a link to add a new task to a plan instance
3. the ability to edit a task instance (description, title, tags, completion date etc)
4. the ability to mark a task as complete or incomplete from

Requirements 1-3, upon save or cancel, will redirect back to the page the user was on before entering these pages.

All editing functionality will only be available to the page owner and when in the editing page mode.

In addition they have also requested the following functionality:
- the ability to select more than one plan instance per blocktype

to reduce the unique number of blocktypes required on the page.

[Kristina Hoeppner (kris-hoeppner)]

In review: https://reviews.mahara.org/#/c/8398/

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8567

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8569

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8581

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8610

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8800

[Steven (stevens-q)]

Preconditions:

1. User plans exist
User has at least 1 task associated with the plan
3. User
has existing plan block on a portfolio page for the existing plan

Test Steps:

CONFIRM BUTTONS for Create edit and delete
---------------------------------------
1. User browse to a portfolio page that contains a "Plan" block in edit mode
2. Confirm the following are displayed
 a. Block title/Plan with gear icon and delete (rubbish bin) icon to the right ✔
NOTE: user can user either the plan title for the plan block title or create a new one
 b. Plan description with edit (pencil) icon, add (+) icon and delete (rubbish bin) icon to the right ✔
 c. Tags associated with the plan ✔
 d. Task title with edit (pencil) icon and delete (rubbish bin) icon to the right ✔
 e. The number of tasks (located bottom right of block) ✔
 f. Details link (located bottom left of block) ✔
3. User click the delete (rubbish bin) icon to the right of Block title/Plan
4. Confirm block is deleted ✔
5. Confirm Plan is not deleted - (go to Main menu > Content > Plans and confirm plan still exists) ✔

EDIT PLAN
--------------------------------------------
6. User is on portfolio page that contains a "Plan" block in edit mode
7. User click the edit (pencil) icon to the right of the plan description
8. Confirm that user is redirected to the plan page in edit mode ✔
9. User makes changed to the plan title and description and click the "Save plan" button
10. Confirm the user is redirected back to the portfolio page in edit mode ✔
11. Confirm that the changes made are now displayed ✔

ADD TASK to PLAN
--------------------------------------------------
12. User is on portfolio page that contains a "Plan" block in edit mode
13. User click the add (+) icon to the right of the plan description
14. Confirm the user is redirected to the New Task page in edit mode ✔
15. User fills in all required fields and clicks the "Save Task" button
16. Confirm the user is redirected back to the portfolio page in edit mode ✔
17. Confirm that a new task has been added to the bottom of the Plan block and the number of tasks have been updated ✔

DELETE PLAN and CANCEL
---------------------------------------------------
18. User is on portfolio page that contains a "Plan" block in edit mode
19. User click the delete (rubbish bin) icon to the right of the plan description
20. Confirm the user is redirected to a delete conformation page with the following ✔
 a. Name of plan to be deleted ✔
 b. Text "Are you sure you wish to delete this plan? Deleting this plan will also remove any tasks it contains."✔
 c. "Delete plan" button✔
 d. Cancel link ✔
21. User click the cancel link
22. Confirm the user is redirected back to the portfolio page in edit mode ✔
23. Confirm no changes have been made ✔

DELETE PLAN and CONFIRM DELETE
-----------------------------------------------------------------
23. User is on portfolio page that contains a "Plan" block in edit mode
24. User click the delete (rubbish bin) icon to the right of the plan description - user is on
25. Confirm the user is redirected to a delete conformation page with the following ✔
26. User click the "Delete plan" button
27. Confirm u...

[Kristina Hoeppner (kris-hoeppner)]

The two issues were fixed in a subsequent patchset.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8569
Committed: https://git.mahara.org/mahara/mahara/commit/01e988c2b61ac9fca23025ed3e5d832f67e2cf7a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 01e988c2b61ac9fca23025ed3e5d832f67e2cf7a
Author: Maria Sorica <email address hidden>
Date: Mon Mar 5 16:38:18 2018 +0000

Bug 1723961: Add edit links for each plan in a block instance

Each plan in a block instance will have a set of
edit, delete and add task links to make the
plan editing easier.

behatnotneeded

Change-Id: If4c9362906d894f4e4e6e0e9a2d59c640ede0506

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8581
Committed: https://git.mahara.org/mahara/mahara/commit/c788dcc0f8a7f9160d1e6e207c507be956d0f73b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c788dcc0f8a7f9160d1e6e207c507be956d0f73b
Author: Maria Sorica <email address hidden>
Date: Tue Mar 6 11:58:41 2018 +0000

Bug 1723961: Allow user to edit tasks from blocktype

1. Each tasks has an edit, delete icon group.
2. Tasks can be marked as complete from
the blocktype when the view is in edit mode.

behatnotneeded

Change-Id: If35431aa438802c3e299af05c84bf3c45cc8a8ac

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8567
Committed: https://git.mahara.org/mahara/mahara/commit/bc40a45fe9befad860128f3b0785c8d2f90727e5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit bc40a45fe9befad860128f3b0785c8d2f90727e5
Author: Maria Sorica <email address hidden>
Date: Mon Mar 5 15:34:07 2018 +0000

Bug 1723961: Allow plan blocktypes to display more than one plan

1. Added a details link for each plan in the blocktype as well.
2. On site update, the existing plan blocktypes will be updated
to be able to contain more than plan.
3. Made task pagination work on blocktypes with
multiple plans.

behatnotneeded

Change-Id: I4b462f447489eb16d43fd40cfa552825c5178a47

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8800
Committed: https://git.mahara.org/mahara/mahara/commit/f94180b43cf29b6cbb360c74d4dd492e2fd51e7d
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit f94180b43cf29b6cbb360c74d4dd492e2fd51e7d
Author: Robert Lyon <email address hidden>
Date: Fri Apr 13 09:08:21 2018 +1200

Bug 1723961: Allow update status of plan task via normal page display

If the viewer is the owner of the page.
This hooks into the functionality used on the edit screen

Also added some padding to 'tags' div within a panel

Also changed the javascript call from being an inline html onclick to
being done via jQuery - allowing us to capture the event and stop the
expander event from being triggered

behatnotneeded

Change-Id: I866486493dacb5c48878c539dbbbde3e841d8b91
Signed-off-by: Robert Lyon <email address hidden>