consolidate behat messages tests

Bug #1719222 reported by Rebecca Blundell on 2017-09-24
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Niranjan

Bug Description

test/behat/features/settings/visible_asterix_message.feature
Is there another send message feature that this could be part of?

Check out these tests and see how we are testing messages and how it can be improved:
./features/social/send_multiple_messages.feature
./features/social/send_message.feature
./features/site_content/activity_type_messages.feature
./features/settings/visible_asterix_message.feature

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: New → In Progress
Changed in mahara:
importance: Undecided → Medium
milestone: none → 18.04.0
Rebecca Blundell (rjb-dev) wrote :

What the tests currently do:

test/behat/features/site_content/activity_type_messages.feature

Background:
Admin sends UserA a message
UserA replies
Scenario:
Check the kinds of message filters available

test/behat/features/social/send_message.feature

Admin sends UserA a message including < & >
Check that sent message includes the same chars

test/behat/features/social/send_multiple_messages.feature

Admin logs in and searches for people
Sends a message to UserA
Requests friendship from UserA with a message that's too long
Checks it's rejected and sends another message
UserA logs in and sees message
Admin logs in and then masquerades as UserB
Requests friendship from Admin
Becomes Admin user and accepts friend request
Masquerades as UserB and checks friend accept options

test/behat/features/settings/visible_asterix_message.feature

Checks that on the send message form there are asterisks on the required fields

Rebecca Blundell (rjb-dev) wrote :

What needs to happen:

send_multiple_messages.feature is already quite complex, so let's leave it as is.

activity_type_messages.feature needs fixing so that the only thing in the background is the user creation.

Add the visible asterisk check to the send_message.feature and delete visible_asterix_message.feature

Niranjan (niranjan528) on 2018-01-24
Changed in mahara:
assignee: Rebecca Blundell (rjb-dev) → Niranjan (niranjan528)

Reviewed: https://reviews.mahara.org/8475
Committed: https://git.mahara.org/mahara/mahara/commit/8413ce2ec8807921d9b108db5ad6cfe41b4a35b3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 8413ce2ec8807921d9b108db5ad6cfe41b4a35b3
Author: Niranjan Bandi <email address hidden>
Date: Fri Jan 26 15:11:27 2018 +1300

Bug 1719222- Background should have only user creation

- Made the changes according to the code review
Everything in the background is now moved to the scenario.
Visible_asterix_message.feature is now moved to send_message.feature.
visible_asterix_nessage.feature is now deleted.

Change-Id: I98c915048d1eff40dce4cd0eb0d62fc1b42913da

Robert Lyon (robertl-9) on 2018-02-12
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers