Participation report doesn't show pages in a collection

Bug #1719216 reported by Kristina Hoeppner
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
18.04
Fix Released
Medium
Robert Lyon

Bug Description

seen in Mahara 17.04

The group participation report is supposed to display pages shared with the group and created within a group. However, it only displays pages when they are not in a collection. As soon as they are in a collection, they are not displayed.

The report should be altered to show "portfolios" shared or created within the group, i.e. individual pages when they are not in a collection and a collection (with the number of pages in parentheses) when there is a collection.

For collections, the comment count should be across all pages that are in the collection.

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8083

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
milestone: 17.10.1 → 18.04.0
no longer affects: mahara/17.10
tags: added: usermanualupdate
Revision history for this message
Niranjan (niranjan528) wrote :

URL: https://bugs.launchpad.net/mahara/+bug/1719216
Bug description: Participation report doesn't show pages in a collection.

Environment to be tested: Master
Browser to be tested: Any browser

Precondition:

1. Normal users ‘User one’,‘User two’ & ‘User three’ should exist.
2. Pages ‘Page 01’, ‘Page 02’ & ‘Page 03’ should exist and ‘User one ‘ is the owner of these pages.
3. A collection exists with the title 'Collection one' and pages within the collection are 'Page 01' and 'Page 02'
4. A group ‘Group one’ should exist and pages ‘Group page01’ and ‘Group page02’ are the pages created within the group.
5. ‘User one’ and ‘User two’ are members of ‘Group one’ and ‘User three’ is not a member.
6. ‘Collection one’ and 'Page 03' shared with ‘Group one’.
7. Comments for ‘Page 01’, ‘Page 02’ & ‘Page 03’ should exist and should have each comment from ‘User one’, ‘User two’ & ‘User three’.
8. Comments for group pages should exist.

Steps to reproduce:

1. Log in as ‘User one’.
2. Navigate to Main menu > Groups.
3. Click the ‘Settings’ button on the group ‘Group one’.
4. Switch ‘Participation report ‘ to ‘Yes’.
5. Click the ‘Save group’ button.
6. Click the ‘Report’ tab.

Expected result:
1. All the pages shared with the Group should be displayed.
2. The pages in the ‘Collection one’ and 'Page 03'should be displayed.
3. Members involved in the group and their comments should be displayed.
4. Non-members involved and their comments should be displayed.
5. Group pages should be displayed.
6. Members involved in the group and their comments should be displayed.

Note: Screen shot will be attached once the test case passes

Revision history for this message
Niranjan (niranjan528) wrote :

Please find the attached screen shot.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Some issues in patchset 6 that will need fixing. See the code review system for comments.

Revision history for this message
Niranjan (niranjan528) wrote :

After few enhancements here is the test case for this bug,

Environment to be tested: Master
Browser to be tested: Any browser

Precondition:

1. Normal users ‘User one’,‘User two’ and ‘User three’ should exist.
2. Pages ‘Page 01’, ‘Page 02’, ‘Page 03’ and ‘Page 04’ should exist and ‘User one‘ is the owner of these pages.
3. A collection exists with the title 'Collection one' and pages within the collection are 'Page 01' and 'Page 02'.
4. ‘User one’ and ‘User two’ are members of ‘Group one’ and ‘User three’ is not a member. ’User one’ is the group admin.
5. Group ‘Group one’ has the following pages:
‘Group page 01’, ‘Group page 02’, ‘Group page 03’ and ‘Group page 04’.
6. A collection exists with the title 'Group collection one' and pages within the collection are 'Group page 01' and 'Group page 02'.
7. Pages and collection at precondition 2 and 3 are shared with the group ‘Group one’.
8. 'User one', 'User two', and 'User three' should have each commented on 'Page 01', 'Page 02', 'Page 03', and 'Page 04' at least once.
9. 'User one', 'User two', and 'User three' should have each commented on 'Group page 01', 'Group page 02', 'Group page 03', and 'Group page 04' at least once.

Steps to reproduce:

1. Log in as ‘User one’.
2. Navigate to Main menu > Groups.
3. Click the ‘Settings’ button on the group ‘Group one’.
4. Switch ‘Participation report ‘ to ‘Yes’.
5. Click the ‘Save group’ button.
6. Click the ‘Report’ tab.

Expected result:

1. The page title is 'Pages and collections shared with this group'.
2. The heading of the first table is 'Shared with this group'.
3. The heading of the second table is 'Owned by this group'.
4. The collection ‘Collection one’ and the pages 'Page 03', 'Page 04' should be displayed under the table heading 'Shared with this group'.
5. Members involved in the group and the number of their comments should be displayed under the column heading ‘Members involved’.
6. Non-members involved and the number of their comments should be displayed under the column heading ‘Non-members involved’.
7. The group collection 'Group collection one' and the group pages ‘Group page 03’, Group page 04' should be displayed under the heading 'Owned by this group'.
8. Members involved in the group and the number of their comments should be displayed under the column heading ‘Members involved' for the table heading ‘Owned by this group'.

Revision history for this message
Niranjan (niranjan528) wrote :

Please find the attachment after my testing,

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8083
Committed: https://git.mahara.org/mahara/mahara/commit/5d65907dba397c716dec6b7c624bbb08d89f5a95
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5d65907dba397c716dec6b7c624bbb08d89f5a95
Author: Robert Lyon <email address hidden>
Date: Mon Oct 2 15:38:04 2017 +1300

Bug 1719216: Include collections in group participation reports

behatnotneeded

Change-Id: I96afb57bba9e2c9195a6ae7b4f76cb1e9354ca72
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8520

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8520
Committed: https://git.mahara.org/mahara/mahara/commit/56d952e3a96df0ee95c95a7b2420dbbed2d4a6ee
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 56d952e3a96df0ee95c95a7b2420dbbed2d4a6ee
Author: Niranjan Bandi <email address hidden>
Date: Tue Feb 13 17:43:42 2018 +1300

Bug 1719216: Participation report to show pages in a collection

Change-Id: Ib0e883b573e672a33828f1452643c3d0a3c36655

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.