A string for the auth plugins is stored in core admin.php lang file rather than in the plugins

Bug #1718289 reported by Robert Lyon on 2017-09-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
16.04
High
Unassigned
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Unassigned

Bug Description

This causes problems for third party plugins as they have a broken lang string unless the user hacks the core file.

To test:
1) Install the CAS plugin from https://github.com/robertlyon777/mahara_plugin_auth_cas
2) Add CAS auth to an institution - The title of the edit screen will be
institution | [[casconfig/admin]]

This string should come from the plugin and not core

Will need to fix up

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8032

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8032
Committed: https://git.mahara.org/mahara/mahara/commit/457d11d15fc66f6b7bd11053ea5fceb89f60ef0e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e
Author: Robert Lyon <email address hidden>
Date: Wed Sep 20 08:58:21 2017 +1200

Bug 1718289: Placing auth related title string in auth plugin

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8033

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8033
Committed: https://git.mahara.org/mahara/mahara/commit/c544f506664629a032ac27271bd9a4e86d87d7ff
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit c544f506664629a032ac27271bd9a4e86d87d7ff
Author: Robert Lyon <email address hidden>
Date: Wed Sep 20 08:58:21 2017 +1200

Bug 1718289: Placing auth related title string in auth plugin

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8034

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8034
Committed: https://git.mahara.org/mahara/mahara/commit/5cf4454699716ea76b0539edbbc4cdeed4691dbc
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 5cf4454699716ea76b0539edbbc4cdeed4691dbc
Author: Robert Lyon <email address hidden>
Date: Wed Sep 20 08:58:21 2017 +1200

Bug 1718289: Placing auth related title string in auth plugin

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e)
(cherry picked from commit c544f506664629a032ac27271bd9a4e86d87d7ff)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "16.04_STABLE" branch: https://reviews.mahara.org/8035

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8035
Committed: https://git.mahara.org/mahara/mahara/commit/ec73dec8cc748612f15556f1fd550c3f3c4fdcfb
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.04_STABLE

commit ec73dec8cc748612f15556f1fd550c3f3c4fdcfb
Author: Robert Lyon <email address hidden>
Date: Wed Sep 20 08:58:21 2017 +1200

Bug 1718289: Placing auth related title string in auth plugin

Rather than in core lang file to allow thirdparty lang strings to work

behatnotneeded

Change-Id: I5b23c471d246f6901695d7fdf102525e9ef8a666
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 457d11d15fc66f6b7bd11053ea5fceb89f60ef0e)
(cherry picked from commit c544f506664629a032ac27271bd9a4e86d87d7ff)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers