"Show more" button on "Pages and collections" doesn't work in a group

Bug #1711443 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
17.04
Fix Released
High
Cecilia Vela Gurovic
17.10
Fix Released
High
Cecilia Vela Gurovic

Bug Description

originally mentioned in https://mahara.org/interaction/forum/topic.php?id=8021

To replicate:

1. Create more than 12 pages / collections in a group.
2. Click the "Show more" button.

Expected result: See more pages / collections.
Actual result: Nothing happens and the "Show more" button just disappears.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7940

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7940
Committed: https://git.mahara.org/mahara/mahara/commit/e470bc633bd45c8ff68c9ed569c6ccd99d3024ed
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e470bc633bd45c8ff68c9ed569c6ccd99d3024ed
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 22 16:45:01 2017 +1200

Bug 1711443: 'Show more' button in group P&C screen

In pagination.js, pagination_showmore function was
expecting the group value from the button clicked
to be a string, but it is a number.

.data() from jQuery converts a string representing
a number to an actual number.

behatnotneeded

Change-Id: If66231211c229f1cf18a5efb35236c2f90ad5a44

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7955

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7955
Committed: https://git.mahara.org/mahara/mahara/commit/57487f149dea839776b05efc5c8a293d010cf930
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 57487f149dea839776b05efc5c8a293d010cf930
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Aug 22 16:45:01 2017 +1200

Bug 1711443: 'Show more' button in group P&C screen

In pagination.js, pagination_showmore function was
expecting the group value from the button clicked
to be a string, but it is a number.

.data() from jQuery converts a string representing
a number to an actual number.

behatnotneeded

Change-Id: If66231211c229f1cf18a5efb35236c2f90ad5a44
(cherry picked from commit e470bc633bd45c8ff68c9ed569c6ccd99d3024ed)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.