Spelling mistake in xmlrpc config form

[Robert Lyon]

A forum user reported:

"I experience an annoying failure with the XML-RPC authentication plugin:

[10-Jul-2017 17:08:09 Europe/Berlin] [WAR] cc (auth/xmlrpc/lib.php:952) Undefined index: active"

This is due to a spelling mistake in the field name - it is 'actve' instead of 'active'

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/7869

[Dominique-Alain JAN (dajan)]

This bug is a duplicate of bug 1702953
https://bugs.launchpad.net/mahara/+bug/1702953

[H. Lekin (hael)]

This reproducible error occurs, after 'Parent authority' or 'We import content' in the XML-RPC configuration has been changed. Then, the plugin state switches from 'Active' Yes to No and the plugin can not be re-activated again.

The provided patch has not been tested yet.

It should be mention, that Mahara runs on PHP 7.1 here.

The missing lines:

[10-Jul-2017 17:08:09 Europe/Berlin] [WAR] cc (auth/xmlrpc/lib.php:952) Undefined index: active
[10-Jul-2017 17:08:09 Europe/Berlin] Call stack (most recent first):
[10-Jul-2017 17:08:09 Europe/Berlin] * log_message(string(size 23), integer, true, true, string(size 45), integer) at /usr/share/webapps/mahara/lib/errors.php:521
[10-Jul-2017 17:08:09 Europe/Berlin] * error(integer, string(size 23), string(size 45), integer, array(size 5)) at /usr/share/webapps/mahara/auth/xmlrpc/lib.php:952
[10-Jul-2017 17:08:09 Europe/Berlin] * PluginAuthXmlrpc::save_instance_config_options(array(size 23), object(Pieform)) at /usr/share/webapps/mahara/lib/mahara.php:1771
[10-Jul-2017 17:08:09 Europe/Berlin] * call_static_method(string(size 16), string(size 28), array(size 22), object(Pieform)) at /usr/share/webapps/mahara/admin/users/addauthority.php:110
[10-Jul-2017 17:08:09 Europe/Berlin] * auth_config_submit(object(Pieform), array(size 22)) at /usr/share/webapps/mahara/lib/pieforms/pieform.php:543
[10-Jul-2017 17:08:09 Europe/Berlin] * Pieform->__construct(array(size 5)) at /usr/share/webapps/mahara/lib/pieforms/pieform.php:164
[10-Jul-2017 17:08:09 Europe/Berlin] * Pieform::process(array(size 5)) at /usr/share/webapps/mahara/lib/mahara.php:4838
[10-Jul-2017 17:08:09 Europe/Berlin] * pieform(array(size 5)) at /usr/share/webapps/mahara/admin/users/addauthority.php:81

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7869
Committed: https://git.mahara.org/mahara/mahara/commit/4e1fd1c7800db73a2a8c140ac83f883eb9a34269
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4e1fd1c7800db73a2a8c140ac83f883eb9a34269
Author: Robert Lyon <email address hidden>
Date: Wed Jul 12 08:31:35 2017 +1200

Bug 1703676: Spelling mistake on 'active' field name

behatnotneeded

Change-Id: Id744f905a407772ff762589e8f1e99fbb96e9cf2
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7894

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7894
Committed: https://git.mahara.org/mahara/mahara/commit/db52cfd059a4a6fa5522dd100afd7a2dfb5b9f6f
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit db52cfd059a4a6fa5522dd100afd7a2dfb5b9f6f
Author: Robert Lyon <email address hidden>
Date: Wed Jul 12 08:31:35 2017 +1200

Bug 1703676: Spelling mistake on 'active' field name

behatnotneeded

Change-Id: Id744f905a407772ff762589e8f1e99fbb96e9cf2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4e1fd1c7800db73a2a8c140ac83f883eb9a34269)