Image can't be linked in TinyMCE via GUI

[Kristina Hoeppner]

Mahara 16.10 (no problem in 17.04 and master):

When you try to link an image in TinyMCE, you can't add a URL.

To replicate:

1. Pull the "Text" block onto a page.
2. Add an image into the text box.
3. Click the link icon (keeping the image selected) and enter a URL.
4. Click the "OK" button.

Expected result: The pop-up box disappears and the image is linked.
Actual result: Nothing happens when you click the "OK" button.

[Cecilia Vela Gurovic (ceciliavg)]

This is a problem of tinyMCE library.

I could replicate the bug in firefox/chrome. But with this fix they made for tinyMCE: https://github.com/tinymce/tinymce/commit/228fb3a91cb9c5c5c8c7213991359d4716c88416 the issue disappears.

This bug is not present in 17.04 because we upgraded the TinyMCE lib to 4.5.5 in it. (Bug: 1672893)

[Mahara Bot (dev-mahara)]

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7836

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/7836
Committed: https://git.mahara.org/mahara/mahara/commit/0f2d01e6504a54fac4cc206593ea09089b1669fb
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 0f2d01e6504a54fac4cc206593ea09089b1669fb
Author: Cecilia Vela Gurovic <email address hidden>
Date: Tue Jun 27 11:39:40 2017 +1200

Bug 1699074: can link url to an image in tinyMCE

Added code to lib from TinyMCE bug fix TINY-929
Only for 16.10, this fix is included in TinyMCE
lib upgrade from 17.04 on

behatnotneeded

Change-Id: Ia5abad9f5fdd93eb0aed7841eac684f4c41d467d