Mahara

Incorrect logo is displayed when selecting subtheme

Bug #1694158 reported by Pat
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
Mahara 17.10.0
17.04
Fix Released
High
Unassigned
Mahara 17.04.3
17.10
Fix Released
High
Unassigned
Mahara 17.10.0

Bug Description

When a custom theme is selected and the logo provided with the theme is a png file, the site logo falls the back to mahara logo (svg version) instead of displaying the png version. This happens after adding svg in as an accepted file extensions in get_image_url function.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

An interim mitigation is to upload the png logo through the front-end in the institution administration.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7793

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7793
Committed: https://git.mahara.org/mahara/mahara/commit/ee6a40863ce0750a6bdb56f04a55398b61174167
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ee6a40863ce0750a6bdb56f04a55398b61174167
Author: Pat Kira <email address hidden>
Date: Mon May 29 20:10:48 2017 +1200

Bug 1694158 - Fix site logo not loading allowed extensions within the
selected custom theme

Fixed the site logo falls the back to mahara logo (svg version) instead of
displaying the png version. This happens after adding svg in as an
allowed file extension.

behatnotneeded

Change-Id: I6cf22bed466b8b7ec86aa1386b8edd54112d37ac

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7906

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7906
Committed: https://git.mahara.org/mahara/mahara/commit/e56aa6216a94bc49db17987bed160f38aa508560
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit e56aa6216a94bc49db17987bed160f38aa508560
Author: Pat Kira <email address hidden>
Date: Mon May 29 20:10:48 2017 +1200

Bug 1694158 - Fix site logo not loading allowed extensions within the
selected custom theme

Fixed the site logo falls the back to mahara logo (svg version) instead of
displaying the png version. This happens after adding svg in as an
allowed file extension.

behatnotneeded

Change-Id: I6cf22bed466b8b7ec86aa1386b8edd54112d37ac
(cherry picked from commit ee6a40863ce0750a6bdb56f04a55398b61174167)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.