Collapse main menu by pressing Esc key

Bug #1692757 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Jaque

Bug Description

Mahara 17.04+

User should be able to collapse the main navigation menus (user menu, admin menu, main menu) by pressing the Escape key.

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 17.10.0 → 18.04.0
Jaque (jaque777)
Changed in mahara:
assignee: nobody → Jaque (jaque777)
Jaque (jaque777)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8523

Revision history for this message
Steven (stevens-q) wrote :

Test steps

1. user logged in as valid user (admin) (non admin user)
2. user is on home dashboard page
3. user clicks the hamburger menu to expand
4. confirm user can close the flyout menu by clicking outside the menu ✔
5. confirm user can close the flyout menu by pressing the Esc key on keyboard ✔
6. confirm user can close the flyout menu by selecting an option in the menu ✔
7. browse to another site page
8. confirm user can close the flyout menu by clicking outside the menu ✔
9. confirm user can close the flyout menu by pressing the Esc key on keyboard ✔
10. confirm user can close the flyout menu by selecting an option in the menu ✔
11. Repeat steps for non admin user ✔

Catalyst QA Approved ✔

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8523
Committed: https://git.mahara.org/mahara/mahara/commit/4e0251a6652bf3769fef97d8025a9226ebda0ff4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4e0251a6652bf3769fef97d8025a9226ebda0ff4
Author: Jaque <email address hidden>
Date: Thu Feb 15 10:56:53 2018 +1300

Bug #1692757: Collapse main menu by pressing Esc key

Add js to hide navigation menu when focus is moved away
from menu or ESC is pressed

behatnotneeded

Change-Id: Ieefc13be65a8c2e7409e9336be13f0d42caa1ed7

Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.