Behat test for shared access to pages

Bug #1692746 reported by Rebecca Blundell on 2017-05-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Medium
Niranjan

Bug Description

There isn't a good test for sharing page access.

It would be good to have a test that creates a number of pages and users and confirms that the users whom the pages are shared with are the only ones that have access to them.

So the test should go to pages and collections, set the access to a particular role, group or individual and confirm that the people shared with are the ones that have access.

There are tests that start to test this function, but they don't comprehensively test it.
/features/user/search_users_by_share_pages.feature
/features/user/registered_users.feature

Changed in mahara:
status: New → In Progress
Niranjan (niranjan528) on 2017-05-23
Changed in mahara:
assignee: nobody → Niranjan (niranjan528)
Changed in mahara:
importance: Undecided → Medium
milestone: none → 17.10.0
Rebecca Blundell (rjb-dev) wrote :

Looking at reconciling the share features. This is a list of tests including sharing. I'm not suggesting combining them all, but doing an audit of functionality and making sure we're not testing the same things in different places.

test/behat/features/group/shared_views_to_group.feature
test/behat/features/institution/institution.feature
test/behat/features/collections/adding_pages_collection.feature
test/behat/features/user/search_users_by_share_pages.feature
test/behat/features/view/max_item_limit_sharedwithme.feature
test/behat/features/view/sharepage.feature
test/behat/features/group/group_view_block.feature
test/behat/features/group/shared_pages_timestamp.feature
test/behat/features/group/shared_views_to_group.feature
test/behat/features/view/share_comments.feature
test/behat/features/view/sharedwithme.feature

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/7964

Rebecca Blundell (rjb-dev) wrote :

I have reviewed this more closely and think these are the things to focus on here:

test/behat/features/group/shared_views_to_group.feature
 - change name to share_with_group.feature
 - make as concise as possible
 - use new date step https://reviews.mahara.org/#/c/7962/ to add relative date/s

test/behat/features/group/group_view_block.feature
 - remove functionality that is tested in share_with_group.feature
 - This test is way too huge. Look at making it more concise.

test/behat/features/group/shared_pages_timestamp.feature
 - combine with share_with_group.feature

test/behat/features/user/search_users_by_share_pages.feature
 - don't confirm login
 - add pages in Background
 - consider combining with the share_with_group.feature

test/behat/features/view/sharepage.feature
 - could be a scenario in a related test, e.g, search_users_by_share_pages.feature

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/8007

Robert Lyon (robertl-9) on 2017-09-28
Changed in mahara:
milestone: 17.10.0 → 18.04.0

Reviewed: https://reviews.mahara.org/8007
Committed: https://git.mahara.org/mahara/mahara/commit/92a72586554bc1f0ad94157d311d162adb613e6d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 92a72586554bc1f0ad94157d311d162adb613e6d
Author: Niranjan Bandi <email address hidden>
Date: Fri Sep 8 15:32:57 2017 +1200

Bug 1692746: Changes to the shared pages feature file.

Donot merge
Done with the changes below
search_users_by_share_pages.feature
don't confirm login
add pages in Background
consider combining with the share_with_group.feature

Change-Id: I96c4f56e93ebcac7073feb7a7b576c354be08494

Robert Lyon (robertl-9) on 2017-11-17
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9) on 2018-04-05
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers