Problem with leaving feedback on copied SE collection annotation

Bug #1689931 reported by Robert Lyon on 2017-05-10
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Robert Lyon

Bug Description

When we copy an annotated smart evidence collection we keep the annotation blocks but don't keep the feedback comments.

This is correct behaviour

But on the copied collection we can't add comments to the annotation block any more.

When trying to add feedback via matrix page it says it's saved but no info is actually saved.

I suspect there must be some disconnect between the copying of the annotation within the collection causing the copied annotation to not know where to connect it's feedback

Robert Lyon (robertl-9) wrote :

Ok, on further investigation the issue is with the artefact_annotation table.

Here we add in the information about what view the annotation is on. It is setting the copied annotation to the old view rather than the new one.

Reviewed: https://reviews.mahara.org/7738
Committed: https://git.mahara.org/mahara/mahara/commit/be26717684a36191d813a6fe8178d248194401c5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit be26717684a36191d813a6fe8178d248194401c5
Author: Robert Lyon <email address hidden>
Date: Thu May 11 13:36:32 2017 +1200

Bug 1689931: Updating the artefact_annotation mapping

When copying a page with an annotation artefact on it

behatnotneeded

Change-Id: Ib40e6c4fdf2c31830c3855dcd5b5eedbcebce875
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7751

Reviewed: https://reviews.mahara.org/7750
Committed: https://git.mahara.org/mahara/mahara/commit/2822ce022020628baa565daca3430d7ac6775f55
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 2822ce022020628baa565daca3430d7ac6775f55
Author: Robert Lyon <email address hidden>
Date: Thu May 11 13:36:32 2017 +1200

Bug 1689931: Updating the artefact_annotation mapping

When copying a page with an annotation artefact on it

behatnotneeded

Change-Id: Ib40e6c4fdf2c31830c3855dcd5b5eedbcebce875
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7751
Committed: https://git.mahara.org/mahara/mahara/commit/30145accf983feb3803d8bb4155b95fb80b5d2f8
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit 30145accf983feb3803d8bb4155b95fb80b5d2f8
Author: Robert Lyon <email address hidden>
Date: Thu May 11 13:36:32 2017 +1200

Bug 1689931: Updating the artefact_annotation mapping

When copying a page with an annotation artefact on it

behatnotneeded

Change-Id: Ib40e6c4fdf2c31830c3855dcd5b5eedbcebce875
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers