Image not shown in group description if not a member of a group

Bug #1688165 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
17.04
Fix Released
Low
Unassigned
17.10
Fix Released
Low
Robert Lyon

Bug Description

Seen in Mahara 16.10 and 17.04 but most likely the case also in earlier versions.

When you include an image in the group description and someone who is not yet a member of the group looks at the group homepage, that someone cannot see the image as only members of the group have access to the files that are saved in a group. In contrast to images added to a text block on a page and the page then being shared and others can see the images, that doesn't work for group homepages. If you add an image to an image block though, you can view the image just fine.

To replicate:

1. Create a group and save it.
2. Add an image to the group description (you can only do that after you saved the group because before then you don't have group files available) and save.
3. Log in as someone else and view the group homepage. Expected result: You see the image. Actual result: You can't and only see the alt text.

There are two possibilities going forward:

1. Correct the permissions so you can view images added to the group description.

2. Remove the possibility to add images in a group description. The images don't show up in the overview page of the available groups. And images can be added easily to the group homepage by using the image block.

It could be worthwhile to discuss not offering the possibility to have all the formatting options for description fields such as group description and page description. In the past, we wanted more formatting options in page descriptions in order to circumvent the column layout which was not flexible enough to have a banner across the entire page. This has been possible for a number of versions now and the need for page description formatting is not so great anymore.

Therefore, I wonder if we could dispense with either all formatting options or at minimum remove the possibility to add images.

No matter the decision, since it's easy to get around the issue with images in the group description, I'm marking this as a low bug.

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

Initial forum topic in which the issue was identified: https://mahara.org/interaction/forum/topic.php?id=7931&post=31891

Revision history for this message
Dominique-Alain JAN (dajan) wrote :

Hello
I know understand why on the French group home page the pictures are not displayed when users are not log in.

I always suspected that the problem was on me, but now it makes sense.

D. JAN

Revision history for this message
Jochen K (jochen-kinsinger) wrote :

Hi,
maybe there is a third possibility.
What do you think about , to have a file-folder in group files with access for non-group members.
So if you are member of several groups you can share a file with other groups if you have access to it. (Like in site-files)
worth thinking about ??

Regards
JK

Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

For that 3rd option, maybe it were easier to expand the file permissions on group files that we already have and not only include admins, members and tutors but also non-members since we can already say which group can view, edit and publish group files.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7718

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 17.10.0
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7718
Committed: https://git.mahara.org/mahara/mahara/commit/4dc2d4891b0108027851fcb70413af4f24b77685
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 4dc2d4891b0108027851fcb70413af4f24b77685
Author: Robert Lyon <email address hidden>
Date: Mon May 8 08:30:36 2017 +1200

Bug 1688165: Checking if user can view group hompage for embedded images

Rather than checking if user has a group role.
As the embedding of images for group description is linked to the
group homepage, so if you can see that you should be allowed to see
the embedded images within it.

behatnotneeded

Change-Id: I81cbe5cff7229967095a6e2293576861202432c0
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7741

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7741
Committed: https://git.mahara.org/mahara/mahara/commit/e8e9159aa88c082170f732ead39321c6cd5881bf
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit e8e9159aa88c082170f732ead39321c6cd5881bf
Author: Robert Lyon <email address hidden>
Date: Mon May 8 08:30:36 2017 +1200

Bug 1688165: Checking if user can view group hompage for embedded images

Rather than checking if user has a group role.
As the embedding of images for group description is linked to the
group homepage, so if you can see that you should be allowed to see
the embedded images within it.

behatnotneeded

Change-Id: I81cbe5cff7229967095a6e2293576861202432c0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 4dc2d4891b0108027851fcb70413af4f24b77685)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.