License block - Only variables should be passed by reference

Bug #1686226 reported by Cecilia Vela Gurovic on 2017-04-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Low
Cecilia Vela Gurovic
16.10
Low
Unassigned
17.04
Low
Cecilia Vela Gurovic
17.10
Low
Unassigned

Bug Description

Only variables should be passed by reference error when adding a Creative Commons License to a page

- Create a page
- In General menu, choose Creative common license block and add it to the page
- Save
- Display page

Then we have the error message:

[WAR] 5d (blocktype/creativecommons/lib.php:45) Only variables should be passed by reference
Call stack (most recent first):

    log_message("Only variables should be passed by reference", 8, true, true, "/home/ceciliavg/maharacode/maharatest/htdocs/block...", 45) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/errors.php:521
    error(8, "Only variables should be passed by reference", "/home/ceciliavg/maharacode/maharatest/htdocs/block...", 45, array(size 4)) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/creativecommons/lib.php:45
    PluginBlocktypeCreativecommons::render_instance(object(BlockInstance), true) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/mahara.php:1771
    call_static_method("PluginBlocktypeCreativecommons", "render_instance", object(BlockInstance), true) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:895
    BlockInstance->render_editing(false, false, true) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:823
    BlockInstance->instance_config_store(object(Pieform), array(size 2)) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/pieforms/pieform.php:543
    Pieform->__construct(array(size 15)) at /home/ceciliavg/maharacode/maharatest/htdocs/lib/mahara.php:4804
    pieform_instance(array(size 15)) at /home/ceciliavg/maharacode/maharatest/htdocs/blocktype/lib.php:1219
    BlockInstance->build_configure_form(true) at /home/ceciliavg/maharacode/maharatest/htdocs/view/blocks.php:72

Reviewed: https://reviews.mahara.org/7692
Committed: https://git.mahara.org/mahara/mahara/commit/fb2671afa04307038eadefbecae43349b61378bb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit fb2671afa04307038eadefbecae43349b61378bb
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 26 10:34:18 2017 +1200

Bug 1686226: fix for php7 error warning for license block

behatnotneeded

Change-Id: Ib5517ea506dddd63ccf449f17e0244bf71c062f5

Robert Lyon (robertl-9) on 2017-04-26
Changed in mahara:
milestone: none → 17.04.0

Reviewed: https://reviews.mahara.org/7695
Committed: https://git.mahara.org/mahara/mahara/commit/6b56d7c1deff2d4a72958fbbed7925705a813006
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 6b56d7c1deff2d4a72958fbbed7925705a813006
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 26 10:34:18 2017 +1200

Bug 1686226: fix for php7 error warning for license block

behatnotneeded

Change-Id: Ib5517ea506dddd63ccf449f17e0244bf71c062f5
(cherry picked from commit fb2671afa04307038eadefbecae43349b61378bb)

Reviewed: https://reviews.mahara.org/7696
Committed: https://git.mahara.org/mahara/mahara/commit/a5ef3bb0240677b81996b0914ddb2f6fca8ea801
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit a5ef3bb0240677b81996b0914ddb2f6fca8ea801
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Apr 26 10:34:18 2017 +1200

Bug 1686226: fix for php7 error warning for license block

behatnotneeded

Change-Id: Ib5517ea506dddd63ccf449f17e0244bf71c062f5
(cherry picked from commit fb2671afa04307038eadefbecae43349b61378bb)
(cherry picked from commit 6b56d7c1deff2d4a72958fbbed7925705a813006)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers